Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data() is not available #16

Closed
codebryo opened this issue Jul 17, 2017 · 4 comments · Fixed by #21
Closed

data() is not available #16

codebryo opened this issue Jul 17, 2017 · 4 comments · Fixed by #21

Comments

@codebryo
Copy link
Contributor

Not sure this is on purpose, but it seems that
wrapper.data() is no longer valid.

Is it preferred to use the vm object directly?
It's still in the API docs of setData() that's why I'm asking.

I checked, and it's no longer in the source code, so I guess it was removed.
Should I update the documentation accordingly?

@eddyerburgh
Copy link
Member

eddyerburgh commented Jul 18, 2017

Yes it's preferred to use the vm. In avoriaz there was data, methods and props. methods caused problems as it was not bound to the vm, and if we bound it to the vm before returning it would be a different reference to a function that was returned, which I thought was unintuitive.

There might be an argument for bring them all back, but for the moment we are encouraging accessing them on the vm.

Great catch 😄 , and yes it would be very much appreciated if you could update the docs!

@codebryo
Copy link
Contributor Author

This was taken care off in #19

@eddyerburgh
Copy link
Member

#19 was merged into master, which means it'll be overwritten when we release. This needs to be merged into the dev branch

@posva
Copy link
Member

posva commented Jul 23, 2017

I imagine it's my turn to close this 😆

@posva posva closed this as completed Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants