Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a getOptions method to Wrapper #35

Closed
alexjoverm opened this issue Aug 28, 2017 · 1 comment
Closed

Add a getOptions method to Wrapper #35

alexjoverm opened this issue Aug 28, 2017 · 1 comment

Comments

@alexjoverm
Copy link

As discussed on #34, the idea of having a getOptions method came up, in the same line than #27 for getAttributes and getProps. This would be an abstraction to access the wrapper.vm.$options internal variable. One of the use cases is to test property validation specs, but there might be others.

What notation to use?

  1. Concise: .options(), attributes(), props()...
  2. Verbose .getOptions(), getAttributes(), getProps()...

Let's discuss it

@eddyerburgh
Copy link
Member

My feelings on this is that we shouldn't add too many aliases. I don't think this a common use case, like props or attributes, and it's not much more code to access the $options object on the vm:

wrapper.vm.$options
wrapper.options()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants