Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patch): clone insert hooks to avoid being mutated during iteration #12905

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

xiaodemen
Copy link
Contributor

@xiaodemen xiaodemen commented Dec 19, 2022

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
repro: https://jsbin.com/zobarureye/edit?html,js,console,output

There is a component called v-switch that is placed inside a transition-group element. The v-switch component has a directive called v-foo, accepts a boolean prop called isOn and switches its template root according to the value of isOn. The v-foo directive has an inserted hook that should be called to ensure that the binding logic is refreshed whenever the template root changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants