fix: the first LF following pre and textarea tag should be ignored, fix #5992 #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javoski
reviewed
Jul 3, 2017
src/compiler/parser/html-parser.js
Outdated
| @@ -59,6 +59,10 @@ const decodingMap = { | |||
| const encodedAttr = /&(?:lt|gt|quot|amp);/g | |||
| const encodedAttrWithNewLines = /&(?:lt|gt|quot|amp|#10);/g | |||
|
|
|||
| // #5992 | |||
| const ignoreFirstLFTagList = makeMap('pre,textarea', true) | |||
| const isIgnoreFirstLf = (tag, html) => tag && ignoreFirstLFTagList(tag.toLowerCase()) && html[0] === '\n' | |||
There was a problem hiding this comment.
Not need to call toLowerCase() here, and it seems <textarea> will never reach to this function since isPlainTextElement('textarea') equals true.
There was a problem hiding this comment.
- html5 tag names are case-insensitive, so we use lower case to compare
- isIgnoreFirstLf will be invoked when in textarea parse https://github.com/vuejs/vue/pull/6022/files#diff-084898b8c9f6d4d2833b18312180ef8fR172
There was a problem hiding this comment.
- It'll call
toLowerCase()when passing true tomakeMapas the second param. - I didn't notice those changes starting from line 172, my fault😂.
There was a problem hiding this comment.
👍 Thanks, I missed it, I'll update.
nickmessing
approved these changes
Jul 9, 2017
|
The naming is much better, thanks 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
fix #5992