fix($vdom): Don't replace input for text-like type change, fix #6313 #6344
Conversation
* build(release weex): ignore the file path of entries * [release] weex-vue-framework@2.4.2-weex.1
| @@ -48,14 +48,12 @@ function sameVnode (a, b) { | |||
| ) | |||
| } | |||
|
|
|||
| // Some browsers do not support dynamically changing type for <input> | |||
| // so they need to be treated as different nodes | |||
There was a problem hiding this comment.
This is not relevant since it affects browsers that Vue doesn't support.
src/core/vdom/patch.js
Outdated
| @@ -27,6 +25,8 @@ import { | |||
| isPrimitive | |||
| } from '../util/index' | |||
|
|
|||
| const isTextInputType = makeMap(TEXT_INPUT_TYPES) | |||
There was a problem hiding this comment.
Maybe we could move function isTextInputType to src/platforms/web/util/element.js.
There was a problem hiding this comment.
@javoski, done, any more feedback?
| }).$mount() | ||
| const node = vm.$el.children[0] | ||
| vm.$el.children[0].value = 'test' | ||
| vm.ok = true |
There was a problem hiding this comment.
Shouldn't it be vm.show? Same goes at 155.
There was a problem hiding this comment.
😆, lol, that is a dumb mistake :D
| waitForUpdate(() => { | ||
| expect(vm.$el.children[0]).toBe(node) | ||
| expect(vm.$el.children[0].value).toBe('test') | ||
| vm.show = false |
There was a problem hiding this comment.
Should also assert the input type attribute.
There was a problem hiding this comment.
@dsonet, done, any more feedback?
|
I would suggest to skip warning in v-model if two changed types are all text-like. We can support full dynamic expression instead of only ternary expression. We can apply the logic in dom-props.js. (Also need to update |
|
@nickmessing I removed the ternary support parts to make this PR more focused. I have some ideas on how to fully support dynamic types on |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
fix #6313