fix #6284: avoid iterating non-observable arrays #6467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
While this introduces a slight behavior change, I believe the only scenario in which this would cause breakage is if an application has a non-reactive object inside of a non-reactive array and is relying on the reactivity system to detect changes to the elements in that array. This seems incredibly unlikely to happen as that use case has already gone to lengths to opt out of reactivity in the first place, so I expect this to be nothing but a performance improvement for those use cases if they exist.
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I am unable to build or run tests. The development setup instructions are insufficient to get a dev environment working due to #4338.