test($compile): #7048 warn if both v-model and v-bind:value used on same element #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpemberton
changed the title
yyx990803
requested changes
Nov 14, 2017
src/compiler/parser/index.js
Outdated
| (!map['type'] || map['type'] === 'text') | ||
| ) { | ||
| var vBind = map['v-bind:value'] ? 'v-bind:value' : ':value' | ||
| warn('v-model and ' + vBind + ' used on the same text input') |
There was a problem hiding this comment.
We could definitely use a more detailed message here - something like "v-bind:value conflicts with v-model on the same element because the latter already expands to a value binding internally"
src/compiler/parser/index.js
Outdated
| process.env.NODE_ENV !== 'production' && | ||
| map['v-model'] && | ||
| (map['v-bind:value'] || map[':value']) && | ||
| (!map['type'] || map['type'] === 'text') |
There was a problem hiding this comment.
This warning should apply to anything that is not:
- type=checkbox
- type=radio
- select
|
Thanks for the feedback @yyx990803 Those changes have now been made. Do you think the tests are sufficient? |
rpemberton
changed the title
yyx990803
requested changes
Nov 16, 2017
src/compiler/parser/index.js
Outdated
| ) { | ||
| var vBindValue = map['v-bind:value'] ? 'v-bind:value' : ':value' | ||
| warn(vBindValue + ' conflicts with v-model on the same element because the latter already expands to a value binding internally') | ||
| } |
There was a problem hiding this comment.
Check looks good now - but I'm not sure if makeAttrsMap is the best place to do this check. Let's place it here since this warning is about v-model.
yyx990803
approved these changes
Nov 16, 2017
lovelope
pushed a commit
to lovelope/vue
that referenced
this pull request
Feb 1, 2018
…js#7056) * test($compile): warn if v-model and :value used on same text input vuejs#7048 * test($compile): make v-model and v-bind:value warning apply to all but exceptions vuejs#7048 * test($compile): move v-model/:value conflict warner to model.js vuejs#7048 * style: split long warning messages onto new lines
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
…js#7056) * test($compile): warn if v-model and :value used on same text input vuejs#7048 * test($compile): make v-model and v-bind:value warning apply to all but exceptions vuejs#7048 * test($compile): move v-model/:value conflict warner to model.js vuejs#7048 * style: split long warning messages onto new lines
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
…js#7056) * test($compile): warn if v-model and :value used on same text input vuejs#7048 * test($compile): make v-model and v-bind:value warning apply to all but exceptions vuejs#7048 * test($compile): move v-model/:value conflict warner to model.js vuejs#7048 * style: split long warning messages onto new lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #7048
I don't have much experience with contributing so any feedback would be very welcome.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)