Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(async component): memory leak after synchronous async loading (fix #9229) #9275

Merged
merged 3 commits into from
Jan 11, 2019

Conversation

adrienbaron
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Co-Authored-By: adrienbaron <adrien@abaron.net>
@manniL
Copy link
Contributor

manniL commented Jan 2, 2019

Awesome work! 👏

@adrienbaron
Copy link
Contributor Author

Hi! Any news on the progress of this PR validation?

@yyx990803 yyx990803 merged commit d21e931 into vuejs:dev Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants