Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inline-template crashing (fix #9361) #9365

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

Itisfilipe
Copy link

@Itisfilipe Itisfilipe commented Jan 24, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The generator function for inline templates genInlineTemplate did not prevent the generation of code when an invalid template was being introduced.

The solution introduced is verifying the existence of the first child before checking for its type, this should prevent the application from crashing trying to access attributes in an undefined child variable.

closes #9361

How to Reproduce

Index HTML
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width,initial-scale=1.0">
    <title>Hello World!</title>
    <!-- This is a development version of Vue.js! -->
    <!-- <script src="https://cdn.jsdelivr.net/npm/vue/dist/vue.js"></script> -->
    <script src="./vue.js"></script>
    <script src="/main.js" type="module"></script>
  </head>
  <body>
    <div id="app"></div>
  </body>
</html>
JS code
// ### main.js ###
import App from "./App.js";

Vue.config.productionTip = false;

new Vue({
  render: h => h(App),
}).$mount(`#app`);


// ### App.js ###
var HelloWorld = {
  name: 'HelloWorld',
  template: `<div></div>`,
  props: {
    msg: String
  }
}

export default {
  name: 'App',
  components: {
    HelloWorld
  },
  template: `
    <div id="app">
      <div is="helloWorld" inline-template></div>
    </div>
  `,
};
Error with current implementation

image

Error with this fix

image

@yyx990803 yyx990803 merged commit 55bfb94 into vuejs:dev Feb 4, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when using inline-template attribute but no children
2 participants