-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security guide #1760
Security guide #1760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid so far. I would also add a paragraph about using SSR that would lead to the SSR guide.
Edit: And here I am accidentally selecting approve instead of comment.
9624193
to
ae96a8e
Compare
@shentao I decided to leave out SSR (at least for now), since most people aren't using it and we already cover security concerns specific to SSR throughout the SSR docs rather than consolidated on a single page. |
What about a short "tip" like this:
|
ae96a8e
to
4d97f52
Compare
@shentao I just added a note at the end. What do you think? |
5f612db
to
4efd9fd
Compare
Perfect! Couldn’t write it better myself. 👍 |
Thank you gentelemen! We really appreciate this! |
Hi this is Dan Doyon from Doctor On Demand, thanks so much for starting the security guide. Being in the business of health care we need to ensure all our products are safe. We are very much looking forward to migrating from AngularJS 1.x to Vue. |
|
||
```html | ||
<style>{{ userProvidedStyles }}</style> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should note here that Vue will refuse to render <style>
tags inside templates.
Looks great. There's one thing I would add: sometimes we receive vulnerability reports on how it's possible to do XSS in Vue templates - and we in general do not consider such cases actual vulnerabilities, because there are two possible cases for this to actual lead to a breach:
|
Hey @chrisvfritz! If you have time, could you please let me know where this one is at? I also wouldn't mind finishing it up for you if you're busy. Thanks! |
Looking to kick start this again @chrisvfritz . |
No description provided.