Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar header extraction improvements #238

Closed
yyx990803 opened this issue Apr 24, 2018 · 3 comments
Closed

Sidebar header extraction improvements #238

yyx990803 opened this issue Apr 24, 2018 · 3 comments
Labels
contribution welcome Contributions welcome type: enhancement Request to enhance an existing feature

Comments

@yyx990803
Copy link
Member

Currently with the following titles:

## `some code`

## <foo>

## [Some link](/)

When extracted into the sidebar they are displayed verbatim. We need to improve the title inference / header extraction logic to handle these cases (Emoji was fixed previously in #206 but it was only one of the many possible cases).

@yyx990803 yyx990803 added type: enhancement Request to enhance an existing feature contribution welcome Contributions welcome labels Apr 24, 2018
@jlooper
Copy link
Contributor

jlooper commented Apr 24, 2018

What if one could write something like this:

## `some code` | This is wicked cool code

Then the part after the pipe could be the displayed title? I've been tinkering with side bars recently...

@ulivz
Copy link
Member

ulivz commented Apr 25, 2018

Cool, some questions:

  1. Just removing `, or keep the <code> style?
## `some code`
  1. Just unescaping it to <foo>?
 ## &lt;foo&gt;
  1. Just removing the link caontainer ?
## [Some link](/)

yyx990803 pushed a commit that referenced this issue Apr 29, 2018
* feat: sidebar header extraction improvements (close: #238)

* chore: add more markdown tokens to be removed

* fix: typo
@ulivz
Copy link
Member

ulivz commented May 11, 2018

Will release it at 0.9.0: #419. 🚀

nuochong added a commit to nuochong/vuepress that referenced this issue Oct 31, 2020
nuochong added a commit to nuochong/vuepress that referenced this issue Nov 17, 2020
nuochong added a commit to nuochong/vuepress that referenced this issue Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome type: enhancement Request to enhance an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants