Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #855 Stop observing add/remove of files in node_modules #856

Merged
merged 1 commit into from
Sep 20, 2018
Merged

fix #855 Stop observing add/remove of files in node_modules #856

merged 1 commit into from
Sep 20, 2018

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Sep 19, 2018

Closes #855

When running vuepress dev, chokidar is set to observe all
addition/removal of md files inside the current folder.

node_modules is one of the observed folders and can contain tons of subfolders. It mostly never contains any md files. Even more rarely has it any hot additions of md files.

Another perk of this fix is this: If for some reason a developer
decided to publish a folder with a weird name in its module. It will not
prevent vuepress dev from loading.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Dev perf

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

node 8.11.4

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Closes #855

When running vuepress dev, chorkidar is set to observe all
addition/removal of md files inside the entity folder.

`node_modules` is one of these folders and can contain tons of
subfolders. It mostly never contains any md files anyway, and
even rarely has any hot additions of md files.

Another perk of this perf fix is this: If for some reason a developer
decided to publish a folder with a weird name in its module. It will not
prevent `vuepress dev` from loading.
@elevatebart elevatebart changed the title fix(dev): Stop observing add/remove of files in node_modules fix(#855): Stop observing add/remove of files in node_modules Sep 19, 2018
@elevatebart elevatebart changed the title fix(#855): Stop observing add/remove of files in node_modules fix #855 Stop observing add/remove of files in node_modules Sep 19, 2018
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to place the documents at a sub directory(e.g. docs) instead of the package's root directory.

But it's worth to add it.

@ulivz ulivz merged commit 2348e75 into vuejs:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with file-set
2 participants