Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with file-set #855

Closed
elevatebart opened this issue Sep 19, 2018 · 1 comment · Fixed by #856
Closed

Conflict with file-set #855

elevatebart opened this issue Sep 19, 2018 · 1 comment · Fixed by #856

Comments

@elevatebart
Copy link
Contributor

Bug report

If I install vuepress v0.14.4 and file-set v2.0.0, running vuepress dev returns the following error:

C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\snapdragon\lib\parser.js:473
        throw new Error('no parsers registered for: "' + self.input.slice(0, 5) + '"');
        ^

Error: no parsers registered for: "].dir"
    at parse (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\snapdragon\lib\parser.js:473:15)
    at Parser.parse (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\snapdragon\lib\parser.js:477:24)
    at Snapdragon.parse (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\snapdragon\index.js:122:28)
    at Snapdragon.<anonymous> (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\lib\braces.js:40:45)
    at Braces.parse (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\lib\braces.js:66:26)
    at Braces.expand (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\lib\braces.js:87:18)
    at create (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\index.js:142:15)
    at memoize (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\index.js:298:13)
    at Function.braces.create (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\index.js:165:10)
    at Function.braces.expand (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\braces\index.js:81:17)
    at getDirParts (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\chokidar\index.js:435:31)
    at FSWatcher.<anonymous> (C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\chokidar\index.js:452:24)
    at C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\readdirp\readdirp.js:220:72
    at Array.filter (<anonymous>)
    at C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\readdirp\readdirp.js:220:12
    at C:\Users\bart.ledoux\Documents\GitHub\vuepress-bug\node_modules\readdirp\readdirp.js:193:38

Version

0.14.4

Steps to reproduce

Checkout this repo https://github.com/elevatebart/vuepress-bug,
then yarn && yarn docs

What is expected?

It should run all the way and display the readme.md

What is actually happening?

Vuepress is observing the node_modules through chokidar and fails to load because of the strange shape of one folder in node_modules

Other relevant information

  • Your OS: Win10
  • Node.js version: 8.11.4
  • Browser version: -
  • Is this a global or local install? local
  • Which package manager did you use for the install? yarn
@elevatebart
Copy link
Contributor Author

I will have a PR ready soon

@elevatebart elevatebart mentioned this issue Sep 19, 2018
Merged
5 tasks
ulivz pushed a commit that referenced this issue Sep 20, 2018
@elevatebart @ulivz
fix(dev): Prevent files at node_modules from being watched (close: #855…
2348e75 
…) (#856)

When running vuepress dev, chorkidar is set to observe all
addition/removal of md files inside the entity folder.

`node_modules` is one of these folders and can contain tons of
subfolders. It mostly never contains any md files anyway, and
even rarely has any hot additions of md files.

Another perk of this perf fix is this: If for some reason a developer
decided to publish a folder with a weird name in its module. It will not
prevent `vuepress dev` from loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #855 Stop observing add/remove of files in node_modules
1 participant
@elevatebart