Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extendCli Plugin Option API #1069

Merged
merged 12 commits into from
Dec 8, 2018
Merged

extendCli Plugin Option API #1069

merged 12 commits into from
Dec 8, 2018

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Dec 4, 2018

Summary

It provides a better way to fulfill these requirements of plugin logic outside of dev and build.

e.g.

Internal changes:

  1. Removed '@vuepress/cli' package;
  2. Modified the compatible node version to 8.6 or higher.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

// @egoist @sulmanweb @LinFeng1997

@ulivz ulivz changed the title Register command plugin api registerCommand Plugin Option API Dec 4, 2018
```js
module.exports = {
registerCommand (cli) {
cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why call it registerCommand when you can get the entire cli instance 😂

Copy link
Member Author

@ulivz ulivz Dec 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is extendCli?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to extendCli at 1f7bf85

@ulivz ulivz changed the title registerCommand Plugin Option API extendCli Plugin Option API Dec 8, 2018
@ulivz ulivz merged commit e963731 into master Dec 8, 2018
@ulivz ulivz deleted the register-command-plugin-api branch March 4, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants