Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test($core): add missing tests for Page #2218

Merged
merged 7 commits into from
Aug 22, 2020
Merged

test($core): add missing tests for Page #2218

merged 7 commits into from
Aug 22, 2020

Conversation

billyyyyy3320
Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 commented Mar 10, 2020

Summary

As we discussed in Core team meeting - "We should do more testing on VuePress".

I decided to start at core package.

Add a bunch of tests, such as

  • permalink
  • page title
  • public api
  • excerpt
  • extract headers
  • add page with explicit content

Let me know if splitting them into multiple files will make them more readable to you.


What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: Test

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320 billyyyyy3320 self-assigned this Mar 10, 2020
@billyyyyy3320 billyyyyy3320 marked this pull request as ready for review March 20, 2020 15:26
@kefranabg
Copy link
Collaborator

@billyyyyy3320 Can I let you check that these tests are still up to date and merge ? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants