Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UID doesn't exist on the getCurrentInstance proxy in VUE3 #1090

Closed
kfras opened this issue Jul 29, 2022 · 0 comments · Fixed by #1091
Closed

UID doesn't exist on the getCurrentInstance proxy in VUE3 #1090

kfras opened this issue Jul 29, 2022 · 0 comments · Fixed by #1091

Comments

@kfras
Copy link

kfras commented Jul 29, 2022

Describe the bug
UID doesn't exist on getCurrentInstance proxy in VUE3. This results in validations being registered as _vuelidate_undefined, which causes issues with multiple validations as they are all registered as the same (thus overwriting).

$registerAs = `_vuelidate_${uid}`

Screen Shot 2022-07-29 at 1 55 31 pm

Expected behavior
Validations should be registered as _vuelidate_xxxx, where xxxx is the VUE instance uid. Instead, they are registered as _vuelidate_undefined.

Additional context
This issue was introduced in this PR #1082 . From what I can see, uid exists only on the internal instance in VUE3 (which the comments in the linked PR mention wanting to avoid using).

dobromir-hristov pushed a commit that referenced this issue Aug 4, 2022
…#1090  (#1091)

* test: 🧪 test that uid are undefined in vue3

* fix(core): 🐛 uid was undefined on vue3

create our own uid to be agnostic of vue version

Co-authored-by: Florent Bouisset <florent.bouisset@jellysmack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant