Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): UID doesn't exist on the component public instance in Vue 3 #1090 #1091

Merged

Conversation

Florent-Bouisset
Copy link
Contributor

Summary

fixes #1090

uid is not on the ComponentPublicInstance but on the ComponentInternalInstance on vue3

we can do as before by accessing the internal instance with instance.$.uid

    const uid = instance?.$?.uid || instance._uid
    $registerAs = `_vuelidate_${uid}`

but accessing internal instance is not recommended, I suggest to create our own uid instead.
The vuelidate uid doesn't need to be same as the vue uid right ?

Metadata

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Florent Bouisset added 2 commits July 30, 2022 12:18
@dobromir-hristov
Copy link
Contributor

I think the UID is not necessary to be the same, but I hope it wont intervene with entire components being rendered on/off.

@dobromir-hristov dobromir-hristov merged commit 8bdf2ac into vuelidate:next Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UID doesn't exist on the getCurrentInstance proxy in VUE3
2 participants