Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] READING_TIME_LOCALES is not defined when plugins.readingTime is set to false #3035

Closed
6 of 8 tasks
vordimous opened this issue Apr 17, 2023 · 1 comment
Closed
6 of 8 tasks
Assignees
Labels
bug Something isn't working has workaround Having solution to bypass the issue

Comments

@vordimous
Copy link
Contributor

Checklist

  • I am using LTS version of Node.js.
  • I am using the latest v2 version of VuePress and VuePress official plugins.
  • I am using the latest v2 version of vuepress-theme-hope and all plugins in this repo.
  • I followed the docs and I double checked my configuration.
  • I have searched FAQ and I did not find the answer.

Package name

vuepress-theme-hope

Which operating system are you using?

  • macOS
  • Windows
  • Linux

Describe the bug

I am trying to disable the reading time field. The only way it would seem to do that is to set the property to false which is allowed by the typing. When doing this, I get the below error:

Uncaught ReferenceError: READING_TIME_LOCALES is not defined
    at define.ts:5:35
(anonymous) @ define.ts:5

Additional context

No response

@vordimous vordimous added the bug Something isn't working label Apr 17, 2023
@Mister-Hope
Copy link
Member

This is something we forgot, we will improve this in next version. If you want to disable reading-time display, remove it from pageInfo or articleInfo

@Mister-Hope Mister-Hope added the has workaround Having solution to bypass the issue label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has workaround Having solution to bypass the issue
Projects
None yet
Development

No branches or pull requests

2 participants