Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Static pages doesn't handle properly multiple space occurrence inside title #154

Closed
1 task done
zmilan opened this issue Jan 4, 2022 · 1 comment · Fixed by #155
Closed
1 task done

[Bug]: Static pages doesn't handle properly multiple space occurrence inside title #154

zmilan opened this issue Jan 4, 2022 · 1 comment · Fixed by #155
Labels
bug Something isn't working
Projects
1.0.1 1.1.0
Milestone
1.1.0

Comments

@zmilan
Copy link
Contributor

zmilan commented Jan 4, 2022

Expected Behavior

When the static page has multiple occurrences of space inside the title, like "Terms and conditions", all spaces should be replaced with a dash "-", like this "terms-and-conditions".

Actual Behavior

Only the first occurrence of space is replaced in the title, so "Terms and conditions" become "terms-and%20conditions"

Possible Solution

Use relpaceAll() instead of replace() for page name and active page.

Steps to reproduce

Create a static page with a title that contain multiple white spaces

What version of vendure integration are you using?

1.0.0

What version of Node.js are you using?

any

What browser (and version) are you using?

any

What operating system (and version) are you using?

any

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@zmilan zmilan added the bug Something isn't working label Jan 4, 2022
zmilan added a commit to zmilan/vendure-1 that referenced this issue Jan 4, 2022
@zmilan
fix(static pages): handling multiple white spaces inside static page …
00840ba 
…title

Fixed issue with handling only the first occurrence of white space in static page title

bug vuestorefront-community#154
@zmilan zmilan mentioned this issue Jan 4, 2022
Merged
9 tasks
@zmilan
Copy link
Contributor Author

zmilan commented Jan 4, 2022

I have submitted a fix: #155

@Baroshem Baroshem added this to the 1.0.1 milestone Jan 5, 2022
@Baroshem Baroshem linked a pull request Jan 5, 2022 that will close this issue
fix(static pages): handling multiple white spaces inside static page #155
Merged
9 tasks
@Baroshem Baroshem added this to In progress in 1.0.1 Jan 5, 2022
zmilan added a commit to zmilan/vendure-1 that referenced this issue Jan 7, 2022
@zmilan
Merge branch 'vuestorefront-community:develop' into bug-vuestorefront…
a6772b1 
…-community#154/static-pages-doesnt-handle-properly-multiple-space-occurrence-inside-title
1.0.1 automation moved this from In progress to Done Jan 7, 2022
@Baroshem Baroshem added this to To do in 1.1.0 via automation Jan 25, 2022
@Baroshem Baroshem moved this from To do to Done in 1.1.0 Jan 25, 2022
@Baroshem Baroshem modified the milestones: 1.0.1, 1.1.0 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
1.0.1
Done
1.1.0
Done
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

fix(static pages): handling multiple white spaces inside static page zmilan/vendure-1
2 participants
@zmilan @Baroshem