-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(static pages): handling multiple white spaces inside static page #155
Conversation
…title Fixed issue with handling only the first occurrence of white space in static page title bug vuestorefront-community#154
Hi @zmilan Thanks for raising this PR. I will merge it in the upcoming days so that we can release it with our new version 1.0.1 :) |
Hi @zmilan Could you please also update the changelog of 1.0.1 in the docs? Apart from that, this PR is ready to be merged :) |
…-community#154/static-pages-doesnt-handle-properly-multiple-space-occurrence-inside-title
Done :) |
Awesome, merging. Well done once again! If you are interested, there are also other bugs and features waiting in the backlog. Just let me know in the certain issue that you are interested so I could assign you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Great work @zmilan! Thanks for your contributions to this project 🙏 👏 |
Hi, @michaelbromley thanks, expect more from me in the next days/months, since I am working on a solid big shop which uses venture and vsf2... but I work on it only part time and still have some challenges with organizing import/update of big amount of products... but once when that is done I would move more to help about vendure and vsf2... |
That sounds great! If you will need help at some point, make sure to ping me in Discord or here directly so that we can help you build your shop. If I am not mistaken, this will be a first live VSF & Vendure shop so remember to give us a note so that we can promote your project as well :) |
@Baroshem Thanks in advance. I am very happy to be part of this community and both tools are awesome... I will give you an update for sure... |
Fixed issue with handling only the first occurrence of white space in static page title
bug #154
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: