Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static pages): handling multiple white spaces inside static page #155

Conversation

zmilan
Copy link
Contributor

@zmilan zmilan commented Jan 4, 2022

Fixed issue with handling only the first occurrence of white space in static page title

bug #154

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…title

Fixed issue with handling only the first occurrence of white space in static page title

bug vuestorefront-community#154
@Baroshem
Copy link
Collaborator

Baroshem commented Jan 5, 2022

Hi @zmilan

Thanks for raising this PR. I will merge it in the upcoming days so that we can release it with our new version 1.0.1 :)

@Baroshem Baroshem linked an issue Jan 5, 2022 that may be closed by this pull request
1 task
@Baroshem
Copy link
Collaborator

Baroshem commented Jan 7, 2022

Hi @zmilan

Could you please also update the changelog of 1.0.1 in the docs? Apart from that, this PR is ready to be merged :)

@zmilan
Copy link
Contributor Author

zmilan commented Jan 7, 2022

Hi @zmilan

Could you please also update the changelog of 1.0.1 in the docs? Apart from that, this PR is ready to be merged :)

Done :)

@Baroshem
Copy link
Collaborator

Baroshem commented Jan 7, 2022

Awesome, merging.

Well done once again!

If you are interested, there are also other bugs and features waiting in the backlog. Just let me know in the certain issue that you are interested so I could assign you :)

Copy link
Collaborator

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Baroshem Baroshem merged commit a42e99c into vuestorefront-community:develop Jan 7, 2022
@michaelbromley
Copy link
Collaborator

Great work @zmilan! Thanks for your contributions to this project 🙏 👏

@zmilan
Copy link
Contributor Author

zmilan commented Jan 7, 2022

Hi, @michaelbromley thanks, expect more from me in the next days/months, since I am working on a solid big shop which uses venture and vsf2... but I work on it only part time and still have some challenges with organizing import/update of big amount of products... but once when that is done I would move more to help about vendure and vsf2...

@Baroshem
Copy link
Collaborator

Baroshem commented Jan 7, 2022

@zmilan

That sounds great! If you will need help at some point, make sure to ping me in Discord or here directly so that we can help you build your shop. If I am not mistaken, this will be a first live VSF & Vendure shop so remember to give us a note so that we can promote your project as well :)

@zmilan
Copy link
Contributor Author

zmilan commented Jan 7, 2022

@Baroshem Thanks in advance. I am very happy to be part of this community and both tools are awesome... I will give you an update for sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Static pages doesn't handle properly multiple space occurrence inside title
3 participants