Skip to content
This repository has been archived by the owner on May 28, 2023. It is now read-only.

introduce orderNumber to order creation endpoint #251

Conversation

Flyingmana
Copy link
Contributor

@Flyingmana Flyingmana commented May 24, 2019

As its common to show customers an OrderNumber which is in no relation to the ID used for the Order Entity, it makes sense to introduce this in a platform agnostic way.

Magento for example uses the increment_id for the order number. It will likely be named different for other systems.

To prevent BC breaks in the future, the name should be carefully thought out.

Currently the recent solution for the MyOrder Page is relying on the existence of increment_id, which may not exist for other Systems.

related issue:
vuestorefront/vue-storefront#2743

Follow Up changes:

  • if this value gets added here, it next needs to be added to the ThankYouPage
  • The MyOrder Page needs to be aligned in usage of this value.
    • needs maybe change on API side?
    • should implement a fallback for systems, which dont have a dedicated OrderNumber?

I left the magentoOrderId unchanged, as Iam not sure about its usage and did not want to provoke a BC break.

@patzick patzick mentioned this pull request May 25, 2019
@patzick
Copy link
Collaborator

patzick commented May 25, 2019

i've updated changelog in #252

@patzick patzick merged commit ca02e28 into vuestorefront:develop May 25, 2019
patzick added a commit that referenced this pull request May 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants