Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to add a product to 'wishlist' or 'be compared' from the product list view #2773

Closed
2 of 7 tasks
GabiDivante opened this issue Apr 23, 2019 · 7 comments
Closed
2 of 7 tasks
Assignees
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA rejected Testers will add this label when something is still wrong vs-hackathon Tasks for the Hackathon
Milestone

Comments

@GabiDivante
Copy link
Collaborator

GabiDivante commented Apr 23, 2019

What is the motivation for adding / enhancing this feature?

The customer can browse products faster by adding them directly to the wishlist or to the comparison from the products list (without going to each products page).

What are the acceptance criteria

We can add visible buttons next to each product or buttons may be visible after hovering over the product photo.
The buttons may look like the ones used on the product page.
The implementation must be consistent with the prepared project:
@StasiekDivante please prepare the visualization.

  • Clicking on the appropriate button will add the product to your wishlist or for comparison.
  • The 'add to compare' button is visible only on the desktop view.

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
@GabiDivante GabiDivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Apr 23, 2019
@pkarw pkarw added 1: Easy vs-hackathon Tasks for the Hackathon labels Apr 23, 2019
@Jensderond
Copy link
Contributor

I don't think this is necessary to do when a new default theme is coming in the near future

@Michal-Dziedzinski Michal-Dziedzinski self-assigned this Jun 18, 2019
@Michal-Dziedzinski Michal-Dziedzinski mentioned this issue Jun 28, 2019
8 tasks
@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 3, 2019
@patzick patzick added this to Backlog in StorefrontUI based theme for VS 1.11 via automation Jul 18, 2019
patzick added a commit that referenced this issue Jul 18, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jul 18, 2019
@patzick patzick closed this as completed Jul 18, 2019
StorefrontUI based theme for VS 1.11 automation moved this from Backlog to Done Jul 18, 2019
Michal-Dziedzinski added a commit that referenced this issue Jul 18, 2019
@alinadivante
Copy link
Collaborator

I don't think so it would be a good idea to display these icons on product images in Compare lisimage

Products from wishlist don't have and it is okay.

And one more thing: When I add product to Compare list/Wishlist from Home Page and I will open product page - Add to favorite / Add to compare options will still be available.

@StasiekDivante what you think about current solution for _
The ability to add a product to 'wishlist' or 'be compared' from the product list view_ ?
image

Maybe better option will be to display these icons permanently, but for example, empty heart - when you add it to your favorites - it will fill up?

@alinadivante alinadivante reopened this Jul 22, 2019
StorefrontUI based theme for VS 1.11 automation moved this from Done to In progress Jul 22, 2019
@alinadivante alinadivante added QA rejected Testers will add this label when something is still wrong and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jul 22, 2019
@Michal-Dziedzinski
Copy link
Collaborator

@alinadivante imo it's nice feature when you can add something to wishlist directely from compare :)

@alinadivante
Copy link
Collaborator

ok, so maybe we just need new design to improve the user experience :)

@pkarw
Copy link
Collaborator

pkarw commented Jul 23, 2019

@alinadivante and @Michal-Dziedzinski I just wanted to be sure: what are the next steps in order to have this feature QA-accepted?

@alinadivante
Copy link
Collaborator

@Michal-Dziedzinski imho we have to fix:

When I add simple product to Compare list/Wishlist from Home Page and I will open product page - Add to favorite / Add to compare options will still be available.

→ there should be Remove from wishlist/compare list option visible

@Michal-Dziedzinski
Copy link
Collaborator

@alinadivante @ArturDivante @pkarw #3293 should fix that

@pkarw pkarw assigned patzick and unassigned Michal-Dziedzinski Aug 22, 2019
@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
@pkarw pkarw closed this as completed Sep 24, 2019
StorefrontUI based theme for VS 1.11 automation moved this from In progress to Done Sep 24, 2019
Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA rejected Testers will add this label when something is still wrong vs-hackathon Tasks for the Hackathon
Projects
No open projects
Development

No branches or pull requests

6 participants