Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed z-indexes of offline badge and cookie notification #3552

Merged

Conversation

phoenixdev-kl
Copy link
Contributor

Related issues

Item 1 (see below) fixes issues related to #2773.

Short description and why it's useful

  1. The wish list and compare icons, which got added in PR Feature/#2773 #3157, overlap the offline badge. I adjusted the z-index of the badge to use the global setting for overlays (-1 to be displayed behind the overlay).
  2. By fixing the offline badge I found that the cookie notification uses a hard coded z-index. In order to be consistent, I adjusted the z-index to also use the global overlays setting.
  3. The text in the offline badge is not really centred, it overlaps the screen by 20 px.
  4. My IDE told me "functionalities" isn't a word, so I changed the whole sentence. Later, after having pushed the changes, I found out that it actually is the correct plural of "functionality". The usage of this word seems to be quite controversial, though.

Screenshots of visual changes before/after (if there are any)

Before After
Overlap before Overlap after
Message before Message after

Which environment this relates to

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

- Improve spelling
- Update translation files
- Remove unnecessary translation from Japanese translation file in core folder as we only need it in theme
Offline badge overlapped the screen on the right side by 20 px, which caused the text inside the badge to be not centered (esp. noticable on small screens, for example at @320 px).
They got overlayed by compare icons (for example on category or product pages) and first, sticky column on compare page
@phoenixdev-kl phoenixdev-kl marked this pull request as ready for review September 15, 2019 10:45
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

@pkarw pkarw merged commit c77cb88 into vuestorefront:develop Sep 16, 2019
@phoenixdev-kl phoenixdev-kl deleted the bugfix/offline-badge-overlap branch September 16, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants