Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#2773 #3157

Merged
merged 24 commits into from
Jul 18, 2019
Merged

Feature/#2773 #3157

merged 24 commits into from
Jul 18, 2019

Conversation

Michal-Dziedzinski
Copy link
Collaborator

Related issues

closes #2773

Short description and why it's useful

I added icons on the product tiles that allow you to add to the wish list and to the list to compare products from the list of products

Screenshots of visual changes before/after (if there are any)

Before:
Zrzut ekranu (5)

After:
Zrzut ekranu (5) — kopia

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@Michal-Dziedzinski Michal-Dziedzinski changed the base branch from master to release/v1.10 June 28, 2019 15:36
@pkarw
Copy link
Collaborator

pkarw commented Jun 29, 2019

Super cool feature! We should merge it in into 1.11 - branch changed

@pkarw pkarw changed the base branch from release/v1.10 to develop June 29, 2019 07:21
@pkarw pkarw requested review from patzick and filrak June 29, 2019 21:26
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, i've found problem with isOnCompare partil refactor and duplicating its logic.

please also update changelog:)

core/modules/compare/components/IsToCompare.ts Outdated Show resolved Hide resolved
core/modules/compare/components/Product.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lukeromanowicz lukeromanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a few refinements and a changelog entry.

core/modules/compare/components/Product.ts Outdated Show resolved Hide resolved
src/themes/default/pages/Compare.vue Outdated Show resolved Hide resolved
src/themes/default/components/core/ProductTile.vue Outdated Show resolved Hide resolved
@Michal-Dziedzinski
Copy link
Collaborator Author

@lukeromanowicz @patzick Can you take a look at changes?

@pkarw
Copy link
Collaborator

pkarw commented Jul 13, 2019

@patzick i belive this is a feature that should be merged in before product page refactoring ring

@pkarw
Copy link
Collaborator

pkarw commented Jul 13, 2019

@Michal-Dziedzinski can you please resolve the conflicts before merge?

@lukeromanowicz
Copy link
Contributor

Looks good after fixes except for one thing:

Are all the formatting changes in changelog ok? @patzick @filrak

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes left

CHANGELOG.md Outdated Show resolved Hide resolved
core/modules/compare/components/IsOnCompare.ts Outdated Show resolved Hide resolved
@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 16, 2019
@filrak
Copy link
Collaborator

filrak commented Jul 16, 2019

Please wait with merging. We need to finish rewriting compare module first ;)

@patzick patzick added the not ready for merge PR is holded. Needs some clarifications or things that need to be finished. label Jul 16, 2019
@Michal-Dziedzinski
Copy link
Collaborator Author

@filrak Who is rewriting it? And when it is planned to finish it?

@filrak filrak self-assigned this Jul 18, 2019
@patzick
Copy link
Collaborator

patzick commented Jul 18, 2019

I've corrected modules registration after #3230

yet i was able to have that kind of things:
image

image

i think we should do something with displaying single compare icon on productTile (when product is not in wishlist) and also remove icon from compare view and make a button above there to remove from compares

cc @alinadivante

@patzick patzick added this to In progress in StorefrontUI based theme for VS 1.11 via automation Jul 18, 2019
StorefrontUI based theme for VS 1.11 automation moved this from In progress to Reviewer approved Jul 18, 2019
@patzick patzick merged commit f20ba54 into develop Jul 18, 2019
StorefrontUI based theme for VS 1.11 automation moved this from Reviewer approved to Done Jul 18, 2019
@patzick patzick deleted the feature/#2773 branch July 18, 2019 09:00
@patzick patzick removed the not ready for merge PR is holded. Needs some clarifications or things that need to be finished. label Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants