-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#2773 #3157
Feature/#2773 #3157
Conversation
Super cool feature! We should merge it in into 1.11 - branch changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature, i've found problem with isOnCompare
partil refactor and duplicating its logic.
please also update changelog:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but needs a few refinements and a changelog entry.
@lukeromanowicz @patzick Can you take a look at changes? |
@patzick i belive this is a feature that should be merged in before product page refactoring ring |
@Michal-Dziedzinski can you please resolve the conflicts before merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes left
Please wait with merging. We need to finish rewriting compare module first ;) |
@filrak Who is rewriting it? And when it is planned to finish it? |
I've corrected modules registration after #3230 yet i was able to have that kind of things: i think we should do something with displaying single compare icon on productTile (when product is not in wishlist) and also remove icon from compare view and make a button above there to remove from compares |
Related issues
closes #2773
Short description and why it's useful
I added icons on the product tiles that allow you to add to the wish list and to the list to compare products from the list of products
Screenshots of visual changes before/after (if there are any)
Before:
![Zrzut ekranu (5)](https://user-images.githubusercontent.com/32803679/60353652-c6d80480-99ca-11e9-8375-b79e8b0181ad.png)
After:
![Zrzut ekranu (5) — kopia](https://user-images.githubusercontent.com/32803679/60353671-d0fa0300-99ca-11e9-984f-4d585c61e852.png)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance