Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration for newsletter subscription #29

Closed
pkarw opened this issue Oct 3, 2017 · 0 comments
Closed

Add an integration for newsletter subscription #29

pkarw opened this issue Oct 3, 2017 · 0 comments
Assignees

Comments

@pkarw
Copy link
Collaborator

pkarw commented Oct 3, 2017

Connected to #26. Newsletter claim should be stored in localstorage (you can add sth like "claims Collection" in /store/index.js:21)

Vue.prototype.$db = {
  ordersCollection: localForage.createInstance({
    name: 'shop',
    storeName: 'orders'
  }),

  categoriesCollection: localForage.createInstance({
    name: 'shop',
    storeName: 'categories'
  }),

  cartsCollection: localForage.createInstance({
    name: 'shop',
    storeName: 'carts'
  })
}

global.db = Vue.prototype.$db // localForage instance

Then add the logic to new store "user" added under store/modules.
Finally, adding new claim should execute SW trigger to send this claim out to the server as orders are synchronized (service-worker-ext.js for details), sth like this should be executed:

import * as sw from 'lib/sw'
sw.postMessage({ config: config, command: types.USER_NEWSLETTER_SIGNUP }) // add user to newsletter

in service-worker-ext.js

  if (event.data.command === 'user/NEWSLETTER_SIGNUP') {
...
}

And then - of course you should add new resource type under vue-storefront-api

@pkarw pkarw added the good first issue Tasks that requires just basic understanding of Vue Storefront label Oct 3, 2017
@karolbzik karolbzik added this to the 0.5.0 PoC with marketing features milestone Oct 30, 2017
@karolbzik karolbzik added enhancement and removed good first issue Tasks that requires just basic understanding of Vue Storefront labels Oct 30, 2017
@karolbzik karolbzik changed the title Add Newsletter subscription Add an integration for newsletter subscription Oct 30, 2017
@pkarw pkarw modified the milestones: 0.5.0 Marketing Features, 0.3.0 Taxes, User Accounts, Newsletter and fixes Dec 4, 2017
@pkarw pkarw self-assigned this Dec 4, 2017
@pkarw pkarw closed this as completed Dec 5, 2017
filrak added a commit that referenced this issue Apr 20, 2020
sethidden pushed a commit that referenced this issue Apr 5, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sethidden pushed a commit that referenced this issue Apr 5, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sethidden pushed a commit that referenced this issue Apr 18, 2024
sethidden added a commit that referenced this issue Apr 18, 2024
* chore: initial structure

* docs: update README

* docs: update README

* docs: update README

* fix: namespace

* docs: update README

* docs: update README

* fix: un char

* Update README.md

* chore: depts update

* chore: versions bump

* chore: add repository page

* chore: add vsf core middlware handling

* docs: readme update

* chore: ignores update

* revert: lib

* chore: editable value handling

* chore: building image object

* chore: version bump

* chore: build clean script

* chore: content items check is array

* chore: version bump

* fix(#7): conditional chaning removed for sb bridge, version bump

* chore: npmignore update

* docs: update README

* chore: version bump

* docs: update README

* chore: added #TechForUkraine

* Update README.md

* Update README.md

* chore(in-3875): storyblok package upgrade (#26)

* chore: swap storyblok packages

* chore: upgrade storyblok package

* chore: update dev dependencies

* chore: update husky

* chore: deactivate sonar cloud check

* chore: install engineering toolkit dependencies

* fix: linting errors

* chore: storyblok bridge file improvements

* chore: changeset

* chore: enable releases from master

* chore: node-version file (#27)

* ci: release (rc) (#28)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: exit pre mode (#29)

* ci: release (#30)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* alokai rebranding (#31)

Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io>

* Add storyblok to root

* conventional pr name is not necessary if we have changesets

* remove labeler on legacy

* run old ci on legacy branch

* Run on all Node versions - don't die if Node 14 fails

* eslint --fix

* manual eslint fixes

* remove labeler

* simplify storyblok devdeps

---------

Co-authored-by: lukasborawski <lukas.borawski@gmail.com>
Co-authored-by: Filip Rakowski <f.rakowskI@hotmail.com>
Co-authored-by: Heitor Ramon Ribeiro <heitor.ramon@gmail.com>
Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Krystian Wlodarski <kryswlo95@gmail.com>
Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io>
sethidden pushed a commit that referenced this issue Apr 23, 2024
sethidden pushed a commit that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants