Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules rewrite, storage refactor, huge clenup #3230

Merged
merged 34 commits into from
Jul 18, 2019

Conversation

filrak
Copy link
Collaborator

@filrak filrak commented Jul 15, 2019

Continuation of #3144

Short description and why it's useful

  • Rewrite of old modules to new API by Bartosz Żądłowski (not fully ready yet)
  • Unification of cache keys (some of theme were different than cache entities in StorageManager or config some had different setters than getters and worked only because of get fallback. Now cache/module/StorageManager/config keys are identical for all of the entities which should end up in easier debugging ;):
    • syncTaskCollection renamed to syncTasks
    • compareCollection renamed to compare
    • cmsData renamed to cms
    • cartsCollection renamed to carts
    • checkoutFieldValues, checkoutFieldsCollection renamed to checkout (there was different getter and setter for same entity, one was fully redundant)
    • ...much more (will be in upgrade notes)
  • Improvements in StorageManager API (added 'init' function)
  • renamed initCacheStorage.ts to cache.ts, add webpack alias for backward compatibility

More code was deleted than added so it's a good one ^^

TODO in the next iteration

  • move storage manager to core/lib and rename to CacheManager

@pkarw
Copy link
Collaborator

pkarw commented Jul 15, 2019

@filrak please remember to add the upgrade notes with these collection name changes

@filrak filrak changed the title [WIP] Modules rewrite & storage refactor Modules rewrite, storage refactor, huge clenup Jul 17, 2019
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work guys!
Just few suggestions from me. With localized word just for consistency :)

CHANGELOG.md Outdated Show resolved Hide resolved
core/store/lib/storage-manager.ts Outdated Show resolved Hide resolved
core/store/lib/storage-manager.ts Outdated Show resolved Hide resolved
core/store/lib/storage-manager.ts Outdated Show resolved Hide resolved
core/store/lib/storage-manager.ts Outdated Show resolved Hide resolved
src/modules/payment-backend-methods/index.ts Outdated Show resolved Hide resolved
filrak and others added 4 commits July 17, 2019 22:15
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
@filrak filrak mentioned this pull request Jul 17, 2019
14 tasks
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this little one in :)

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Filip for changes, everything's great! :)
CI also passed, so i merge that"little one" in ;P

@patzick patzick merged commit bd24ae8 into vuestorefront:develop Jul 18, 2019
@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 18, 2019
@patzick patzick mentioned this pull request Jul 18, 2019
8 tasks
@pkarw
Copy link
Collaborator

pkarw commented Jul 18, 2019

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants