Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explain replacement for VListItemAvatar/Icon #72

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

yutak23
Copy link
Contributor

@yutak23 yutak23 commented Oct 26, 2023

For VListItemAvatar and VListItemIcon, i have changed to custom so that the substitution method is clear, and the message is what is written in the official Vuetify3 reference.

v-list-item-icon and v-list-item-avatar have been removed, use v-list-item with icon or avatar props, or put an icon or avatar in the append or prepend slot.

cf. https://vuetifyjs.com/en/getting-started/upgrade-guide/#v-list

This will make it easier for users of VListItemAvatar and VListItemIcon to migrate to Vuetify3.

@yutak23
Copy link
Contributor Author

yutak23 commented Nov 6, 2023

@KaelWD

I would appreciate it if you could review and respond to the content of the PR.

@KaelWD KaelWD changed the title fix: Specify the replacement target for VListItemAvatar and VListItemIcon fix: explain replacement for VListItemAvatar/Icon Dec 8, 2023
@KaelWD KaelWD merged commit 14d7a04 into vuetifyjs:master Dec 8, 2023
3 checks passed
@yutak23 yutak23 deleted the feature/fix-message-vlistitem branch December 8, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants