-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(VSelect): resolve bug in safari/ie11 with event order disparity
the ordering of events in safari/ie11 caused our manual blur of the input to break tabbing through inputs. also resolved duplicate blur events. fixes #6608, fixes #5913
- Loading branch information
1 parent
4963f72
commit 5fa6a68
Showing
3 changed files
with
17 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be included in version 1 too?
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to. I'll mark this as a post 2.0 release resolution for v1.5
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea on when this patch will be applied to v1.5?
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1.5 patches will start next week.
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you give us an update if it comes with a patch for v.1.5 ?
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnleider, @KaelWD: please, can anyone confirm (or NOT) if this PR will be included on v1.5 branch?
The bug was opened on Feb. 26, PR to fix it on Jun. 19 (v2 branch), v1.5 patches starts on Jul. 24 and we are on Sep. 4.
I dont want to wait another 6 months ;).
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea. I'll add it for next week's release.
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnleider Did this end up getting released for v1.5? I am still seeing the behavior as of v1.5.19 and couldn't find a release with this commit in the notes. Sorry if I am just missing something. Thanks!
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any progress on this being included in v1 branch?
5fa6a68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victorwpbastos I put up the PR and it is now included in v1.5.23