Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick wrong date in text field #2022

Closed
CasperLaiTW opened this issue Oct 5, 2017 · 30 comments
Closed

Pick wrong date in text field #2022

CasperLaiTW opened this issue Oct 5, 2017 · 30 comments
Assignees

Comments

@CasperLaiTW
Copy link

CasperLaiTW commented Oct 5, 2017

Steps to reproduce

  1. open https://vuetifyjs.com/components/pickers
  2. Section #3 Date pickers - In dialog and menu
  3. Click TextFields
  4. Pick a date
  5. Get date after 1 month and 1 day on textfield

pick wrong

Versions

Vuetify: 0.16.0
Browser: Chrome 61.0.3163.100

Reproduction Link

https://vuetifyjs.com/components/pickers

@KaelWD
Copy link
Member

KaelWD commented Oct 5, 2017

What timezone are you in?

@jacekkarczmarczyk Looks like it might be that timezone bug back again...

@CasperLaiTW
Copy link
Author

My timezone is +08:00

@johnleider johnleider added the pending review The issue is still pending disposition label Oct 5, 2017
@johnleider
Copy link
Member

Can you please check one more time to see if this issue is happening.

@jacekkarczmarczyk
Copy link
Member

This issue might occur on some specific hours, so it's best if you check at the same time of the day as before (and write in comment what time did you check)

@nekosaur
Copy link
Member

nekosaur commented Oct 6, 2017

Or you know, change the system time :)

@jacekkarczmarczyk
Copy link
Member

I know, but system automatically reverts to the real time, probably it could be blocked somewhere

@KaelWD
Copy link
Member

KaelWD commented Oct 6, 2017

image

@jacekkarczmarczyk
Copy link
Member

OK, I didn't see this because it shows only when you're logged in as an admin

@jacekkarczmarczyk jacekkarczmarczyk added the S: needs reproduction The issue does not contain a valid reproduction label Oct 6, 2017
@CasperLaiTW
Copy link
Author

Hi, I recorded my screen.
This is my local time, Friday, 6 October 2017.
2017-10-06 11 14 06 pm

And this is using picker and get results.

datepicker

Section #1, Section #2 and Section #4 display date is correct, but day of week in head is wrong. 5th Oct. is thursday not friday.

Section #3 and Section #5 is wrong when pick

@jacekkarczmarczyk
Copy link
Member

That's weird, the information given by you looks perfect, however I still cannot reproduce it... I've set CST+8:00 time zone and checked now in Chrome/Firefox/Explorer/Edge and everywhere I'm getting correct results :/
Can you run Intl.DateTimeFormat().resolvedOptions().timeZone and new Date().toISOString() in console and send the result?

@CasperLaiTW
Copy link
Author

something interesting, I got timezone America/Chicago
2017-10-06 11 37 23

But my system time zone is Taipei Standard Time. weird.
screen shot 2017-10-06 at 11 42 49 pm

@jacekkarczmarczyk
Copy link
Member

jacekkarczmarczyk commented Oct 6, 2017

Last question (for now) - what browser are you using?

EDIT: If it's safari then I've found something this: moment/moment-timezone#502

@CasperLaiTW
Copy link
Author

screen shot 2017-10-06 at 11 51 50 pm

Chrome Version 61.0.3163.100 (Official Build) (64-bit)

@KaelWD
Copy link
Member

KaelWD commented Oct 6, 2017

Open Terminal and run echo $TZ

@jacekkarczmarczyk
Copy link
Member

And run this in console new Date()
And BTW maybe you can chat on discord channel? https://chat.vuetifyjs.com

@CasperLaiTW
Copy link
Author

@KaelWD got nothing.

@jacekkarczmarczyk got timezone is +00:00
screen shot 2017-10-06 at 11 57 08 pm

@peluprvi
Copy link
Contributor

peluprvi commented Oct 6, 2017

I found some related issues in moment.js:
moment/moment-timezone#441
moment/moment-timezone#517

They use Intl.DateTimeFormat().resolvedOptions().timeZone too.

@jacekkarczmarczyk jacekkarczmarczyk removed the S: needs reproduction The issue does not contain a valid reproduction label Oct 6, 2017
@eelcowen
Copy link

eelcowen commented Oct 9, 2017

I found that March was duplicated in my view:

schermafbeelding 2017-10-09 om 09 58 01

I clicked in March 1 and the date correctly got selected.

Then i went one month further and I see March again....

schermafbeelding 2017-10-09 om 09 58 08

Now i click on March one and April two gets selected....

new Date().toISOString()
"2017-10-09T08:07:59.804Z"

Intl.DateTimeFormat().resolvedOptions().timeZone
"CET"

@jacekkarczmarczyk
Copy link
Member

What vuetify version?

@eelcowen
Copy link

eelcowen commented Oct 9, 2017

Latest 0.16.4

I'm digging now and i get an error VDatePicker.js --> computed --> timeZone --> catch block
RangeError: Expected Area/Location(/Location)* for time zone, got CET

@jacekkarczmarczyk
Copy link
Member

and chrome@OSX?

@eelcowen
Copy link

eelcowen commented Oct 9, 2017

Yes

@KaelWD
Copy link
Member

KaelWD commented Oct 9, 2017

Looks like a chrome bug from a few years ago: https://bugs.chromium.org/p/chromium/issues/detail?id=364374

@elceka
Copy link

elceka commented Oct 12, 2017

Chrome 61.0.3163.100
OSX 10.11.6

March 2017 multiple 26 day in order.

snimka obrazovky 2017-10-12 o 12 28 35

snimka obrazovky 2017-10-12 o 12 28 52

snimka obrazovky 2017-10-12 o 12 29 00

snimka obrazovky 2017-10-12 o 12 29 08

snimka obrazovky 2017-10-12 o 12 33 18

snimka obrazovky 2017-10-12 o 12 33 29

@elceka
Copy link

elceka commented Oct 12, 2017

Error presence from the Vuetify version 0.16.0-beta.5, in the version 0.16.0-beta.3 is not this error.
Tested on the same environment then i wrote before.

@peluprvi
Copy link
Contributor

peluprvi commented Oct 12, 2017

@elceka Did you tried it on v0.16.5?

@elceka
Copy link

elceka commented Oct 12, 2017

@peluprvi Please, check my issue #2156

@jacekkarczmarczyk
Copy link
Member

@elceka can you check your issue using the following template https://codepen.io/CasperLai/pen/MEGJOL? (Use your code, don't change external javascripts)
It uses Vuetify with PR that should fix time zone related issues

@elceka
Copy link

elceka commented Oct 12, 2017

@jacekkarczmarczyk Seems like be OK with that template.

@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants