Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] add ability to show content inside v-progress-linear #3768

Closed
greenya opened this issue Apr 4, 2018 · 4 comments
Closed

[Feature Request] add ability to show content inside v-progress-linear #3768

greenya opened this issue Apr 4, 2018 · 4 comments
Labels
good first issue A quick-win fix that would be great for new contributors T: feature A new feature
Milestone
v1.5.0

Comments

@greenya
Copy link

greenya commented Apr 4, 2018

Hello!

Problem

v-progress-linear has no ability to show text on the bar, So right now its not possible to have progress bars like these
progress-with-text

Proposed solution

Please add ability (slot) similar to v-progress-circular so it will be possible to add content and align it (left, right, center).
@KaelWD KaelWD added the T: feature A new feature label Apr 6, 2018
@spezzino spezzino mentioned this issue May 21, 2018
Closed
9 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Jun 12, 2018
@KaelWD KaelWD mentioned this issue Jun 20, 2018
Closed
@kungfoome
Copy link

What's going on with this PR #4106? Is it still missing something?

@lcherone
Copy link

lcherone commented Sep 14, 2018 •
edited
Loading

@kungfu71186 Its missing motivation. 16 line change and now a conflict. classic!

@zeidanbm
Copy link

zeidanbm commented Nov 5, 2018

I think a simple workaround can be used with some styling. check out this codepen

@greenya
Copy link
Author

greenya commented Nov 29, 2018

In the time i needed it i came up with own implementation. You can see it here https://greenya.github.io/knaipa/#/members/Terokkar/Crimson/reputation and for actual implementation see page source and search for app-progress-linear.

@KaelWD KaelWD added good first issue A quick-win fix that would be great for new contributors and removed S: has PR The issue has a pending Pull Request labels Nov 29, 2018
@nekosaur nekosaur mentioned this issue Jan 12, 2019
Merged
8 tasks
johnleider pushed a commit that referenced this issue Jan 13, 2019
@nekosaur @johnleider
feat(VProgressLinear): add support for content inside progress bar (#…
7d357e8 
…6126)

resolves #3768
johnleider pushed a commit that referenced this issue Jan 13, 2019
@nekosaur @johnleider
feat(VProgressLinear): add support for content inside progress bar (#…
ee2387c 
…6126)

resolves #3768
johnleider added a commit that referenced this issue Jan 13, 2019
@johnleider
feat(VAlert): refactor for v2 (#6107)
c889973 
* chore(VAlert): move style and test files

* refactor(VAlert): implement styles and cleanup file

* refactor(VAlert): add sensible defaults for dark, remove outline from small icons

* feat(VAlert): add new styles

new props, border, colored-border, closeLabel, dense and prominent

* refactor(VAlert): remove margin-bottom

* docs(kitchen): update alerts kitchen

* chore(VAlert): rename spec file to .ts

* test(VAlert): update unit tests to vue-test-utils

* fix(VAlert): icon colors used with various props

* docs(VAlert): update documentation / add prop information

* refactor(VAlert): remove show, add value, make default true

* refactor(VAlert): cleanup files

* docs: revert package name

* chore(scripts): update build alias

* chore(scripts): add dev alias

* chore(script): set const to let

* docs(grid): fix example lint errors

* feat(VProgressLinear): add support for content inside progress bar (#6126)

resolves #3768

* feat: add croatian locale (#6125)

* feat: Add Croatian translation

* feat: Add croatian to locale index

* feat(VTreeview): add return-object prop (#6064)

* enh(VTreeview): added return-object prop

return-object prop defaults to false and will return the whole node
item object instead of just the key when set to true. this affects
v-model, active.sync and open.sync props.

resolves #5881

* docs(VTreeview): added return-object prop description

* refactor: avoid unnecessary loop

* Add Thai translation. (#6088)

* Add Thai translation

* Add Thai translation

* Delete space on top of file

* feat(VSparkline): add bar type (#6080)

* revert: revert 56f7cd3

* revert: revert f137252

* refactor(VSparkline): cleanup code, fix bar labels and size

* feat(kitchen): prominent outline alerts

* docs(kitchen): fix headers in VAlert pan

* refactor(VAlert): improve dismissible functionality and dense styles

* fix(VAlert): properly handle variants of icon prop

* feat: added outline dense, fixed no-icon example

* docs(kitchen): fix lint in dividers

* docs: fix ecosystem file spawn and script name for playground

* feat(VAlert): add variable for border width

* docs(kitchen): fix alert example

* fix: border in rtl mode

* fix: spacing in rtl mode

* docs(alert): fix outline closable

* docs(alert): fix outline depricated

* fix(VAlert): adjust margin for large dismissible

btn is 12px larger than icon, need to compensate

* fix(VAlert): adjust dismissible color on focus
@KaelWD KaelWD added this to the v1.5.0 milestone Jan 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue A quick-win fix that would be great for new contributors T: feature A new feature
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
7 participants
@kungfoome @nekosaur @greenya @lcherone @zeidanbm @jacekkarczmarczyk @KaelWD