Add content to v-progress-linear #4106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekkarczmarczyk
added
the
S: needs docs update
jacekkarczmarczyk
requested changes
Jun 17, 2018
| @@ -109,6 +109,15 @@ export default { | |||
| this.genBar(h, 'long'), | |||
| this.genBar(h, 'short') | |||
| ]) | |||
| }, | |||
| genContent (h) { | |||
| const children = [this.$slots.default] | |||
There was a problem hiding this comment.
return this.$slots.default && h('div', {
staticClass: 'v-progress-linear__content'
}, this.$slots.default)| position: absolute | ||
| top: 0 | ||
| left: 0 | ||
| bottom: 0 |
There was a problem hiding this comment.
left: 0 is not necessary
|
Changes applied @jacekkarczmarczyk |
Codecov Report
@@ Coverage Diff @@
## dev #4106 +/- ##
========================================
+ Coverage 88.89% 89.6% +0.7%
========================================
Files 227 206 -21
Lines 5376 4876 -500
Branches 1360 1230 -130
========================================
- Hits 4779 4369 -410
+ Misses 479 408 -71
+ Partials 118 99 -19
Continue to review full report at Codecov.
|
KaelWD
added
the
S: has merge conflicts
KaelWD
force-pushed
the
dev
branch
2 times, most recently
from
590b80c
to
214e561
Compare
|
Please resolve conflicts. |
|
@spezzino please resolve conflicts and remove irrelevant commits |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds default slot rendering to v-progress-linear, so content can be added inside the progress bar.
Motivation and Context
Resolves #3768
How Has This Been Tested?
visually tested
Markup:
Types of changes
Checklist:
masterfor bug fixes,devfor new features and breaking changes).