Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] grow/shrink classes don't function as expected #5272

Closed
frattaro opened this issue Oct 11, 2018 · 1 comment
Closed

[Enhancement] grow/shrink classes don't function as expected #5272

frattaro opened this issue Oct 11, 2018 · 1 comment
Assignees
@KaelWD
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features
Milestone
v2.0.0

Comments

@frattaro
Copy link

Versions and Environment

Vuetify: 1.2.5
Vue: 2.5.17
Browsers: Vivaldi
OS: Windows 10

Steps to reproduce

d-flex on parent element, shrink class on immediate child

inspect class="shrink" behavior, it is overridden by d-flex>* selector specificity

Expected Behavior

shrink class should override flex-grow

Actual Behavior

class did not affect the cascade result

Reproduction Link

https://codepen.io/frattaro/pen/NOgdmo
@johnleider
Copy link
Member

Will be resolved in 2.0 with the grid refactor

@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Nov 1, 2018
@johnleider johnleider added this to the v2.0.0 milestone Nov 1, 2018
@MajesticPotatoe MajesticPotatoe changed the title grow/shrink classes don't function as expected [Enhancement] grow/shrink classes don't function as expected Dec 7, 2018
@MajesticPotatoe MajesticPotatoe added the C: VGrid Covers issues involving VContainer, VLayout, VFlex label Apr 10, 2019
@KaelWD KaelWD self-assigned this May 29, 2019
@KaelWD KaelWD mentioned this issue Jul 16, 2019
Merged
4 tasks
@johnleider johnleider modified the milestones: v2.0.0, v2.x.x Jul 18, 2019
@KaelWD KaelWD modified the milestones: v2.x.x, v2.0.0 Jul 19, 2019
KaelWD added a commit that referenced this issue Jul 19, 2019
@KaelWD
feat: use a bootstrap-style grid system (#7327)
9c122fe 
resolves #1434
fixes #5168
resolves #5272
resolves #6020
resolves #7733

* feat: create legacy-grid package

* chore: output dev bundle

* refactor: move VForm grid overrides to legacy-grid

* feat: create new grid components

* feat: add utilities

* feat: create utility classes

* refactor: move utilities css out of component folder

* feat(VRow): add breakpoint align/justify props

* chore: remove test script

* feat: don't publish legacy-grid package

It needs some customisation to lerna to play nicely with our monorepo
setup. We can still publish manually if needed.

* refactor: use generate-utility in more places

* feat(VGrid): revert some breaking changes to classes

* fix(build): remove mqpacker

breaks ordering of grid breakpoints

* feat(grid): add horizontal gutters

* feat(spacers): use linear spacer progression

BREAKING CHANGE: all ma-x etc. helpers need to be changed

before: 0 4 8 16 24 48
after:  0 4 8 12 16 20 24 28 32 36 40 44 48

* refactor(VCol): remove redundant col prop

* fix(VCol): apply class when breakpoints specified

* feat: merge legacy-grid back into vuetify

v-layout and v-flex now coexist with the new components

some styles will still change from 1.x as there is some overlap between
the two systems, but the overall upgrade workload should be less

* docs: update classes

* feat: add back start/end spacing helpers for rtl

* feat: revert space-between -> between breaking change

* style: fix lint

* test: update snapshots

* docs: revert space-between -> between breaking change

partially reverts fc21169

* chore(ci): build before lint

eslint-plugin-vuetify needs to import from dist

* style: fix lint

* fix(VDataTable): replace text-xs-start

* style: fix lint

* fix(VRow): add flex-grow for IE11
@KaelWD KaelWD closed this as completed Jul 20, 2019
This was referenced Jul 23, 2019
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
This was referenced Jul 23, 2019
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
This was referenced Aug 13, 2019
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2019
Closed
Merged
Closed
Closed
@renovate renovate bot mentioned this issue Sep 29, 2019
Merged
1 task
@renovate renovate bot mentioned this issue Aug 23, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
4 participants
@johnleider @frattaro @KaelWD @MajesticPotatoe