-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] More spacer intervals #7733
Comments
is size 4 is now 24px value? if yes, is it official =)? |
4 tasks
Hello and thank you for improving the spacing for vuetify! Are you by any chance also adding 12px? needed for left and right paddings/margins so it totals up to 24px |
KaelWD
added a commit
that referenced
this issue
Jul 19, 2019
resolves #1434 fixes #5168 resolves #5272 resolves #6020 resolves #7733 * feat: create legacy-grid package * chore: output dev bundle * refactor: move VForm grid overrides to legacy-grid * feat: create new grid components * feat: add utilities * feat: create utility classes * refactor: move utilities css out of component folder * feat(VRow): add breakpoint align/justify props * chore: remove test script * feat: don't publish legacy-grid package It needs some customisation to lerna to play nicely with our monorepo setup. We can still publish manually if needed. * refactor: use generate-utility in more places * feat(VGrid): revert some breaking changes to classes * fix(build): remove mqpacker breaks ordering of grid breakpoints * feat(grid): add horizontal gutters * feat(spacers): use linear spacer progression BREAKING CHANGE: all ma-x etc. helpers need to be changed before: 0 4 8 16 24 48 after: 0 4 8 12 16 20 24 28 32 36 40 44 48 * refactor(VCol): remove redundant col prop * fix(VCol): apply class when breakpoints specified * feat: merge legacy-grid back into vuetify v-layout and v-flex now coexist with the new components some styles will still change from 1.x as there is some overlap between the two systems, but the overall upgrade workload should be less * docs: update classes * feat: add back start/end spacing helpers for rtl * feat: revert space-between -> between breaking change * style: fix lint * test: update snapshots * docs: revert space-between -> between breaking change partially reverts fc21169 * chore(ci): build before lint eslint-plugin-vuetify needs to import from dist * style: fix lint * fix(VDataTable): replace text-xs-start * style: fix lint * fix(VRow): add flex-grow for IE11
4 was always 24px
|
if we have 24px on each sides of the cards it will be a 48. That's why we need 12px so that it totals to 24px. |
This was referenced Jul 23, 2019
Closed
This was referenced Jul 23, 2019
This was referenced Aug 13, 2019
This was referenced Sep 20, 2019
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem to solve
$spacers skips some values and doesn't increase linearly, eg. there's no 12px or 32px option
Proposed solution
Add
$spacer * 0.75
and$spacer * 2
values, or just do 4px increments up to 48px.The text was updated successfully, but these errors were encountered: