Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Better gutter/grid system #6020

Closed
ibrahimBeladi opened this issue Jan 1, 2019 · 2 comments
Closed

[Feature Request] Better gutter/grid system #6020

ibrahimBeladi opened this issue Jan 1, 2019 · 2 comments
Assignees
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features T: feature A new feature
Milestone

Comments

@ibrahimBeladi
Copy link
Contributor

Problem to solve

Currently, the grid (grid-list-{xs through xl}) have some kind of limitation, when you use grid-list-md for example in a container, the gutter is applied to inner flex tags. When you want to increase elements' gutter within that flex you can use, for instance, grid-list-xl and it will be applied to whatever within that flex's container. But the problem is when you want to apply a smaller gutter, or you want to remove it altogather, unfortunatly you can't.

Proposed solution

I propose to change the precedence to the other way, md have higher precedence than xl. This will rotate the problem to the other prespective and make the same problem. But since the inner elements have less space then they are more likely to have smaller gutters than larger ones.
Also, I have been thinking about the possibility of taking out the grid, as a new independent component, out of the container component.

This will provide better usage and utilization of the power of the grid. Also, and the possibility of deeper user interface customization.

Codepen example

Sorry for the long post, but wanted to be as detailed as possible.
Happy new year!

@dsseng dsseng added T: enhancement Functionality that enhances existing features T: feature A new feature maybe Functionality that we are considering labels Jan 1, 2019
@johnleider johnleider removed the maybe Functionality that we are considering label Jan 2, 2019
@johnleider johnleider added this to the v2.0.0 milestone Jan 2, 2019
@mattgreenfield
Copy link

I'm having this issue too, it seems the fix would be pretty simple (adding a child combinator > in the CSS) but would be a breaking change with pretty drastic consequences!

If it's any use I made this codepen before coming across this issue, it's a little simpler than the original post https://codepen.io/anon/pen/QoOXoX?editors=1010

For now I'll have to stop using the vuetify grid and roll my own.

@MajesticPotatoe MajesticPotatoe added the C: VGrid Covers issues involving VContainer, VLayout, VFlex label Apr 9, 2019
@KaelWD KaelWD self-assigned this May 29, 2019
@johnleider johnleider modified the milestones: v2.0.0, v2.x.x Jul 18, 2019
@KaelWD KaelWD modified the milestones: v2.x.x, v2.0.0 Jul 19, 2019
KaelWD added a commit that referenced this issue Jul 19, 2019
resolves #1434
fixes #5168
resolves #5272
resolves #6020
resolves #7733

* feat: create legacy-grid package

* chore: output dev bundle

* refactor: move VForm grid overrides to legacy-grid

* feat: create new grid components

* feat: add utilities

* feat: create utility classes

* refactor: move utilities css out of component folder

* feat(VRow): add breakpoint align/justify props

* chore: remove test script

* feat: don't publish legacy-grid package

It needs some customisation to lerna to play nicely with our monorepo
setup. We can still publish manually if needed.

* refactor: use generate-utility in more places

* feat(VGrid): revert some breaking changes to classes

* fix(build): remove mqpacker

breaks ordering of grid breakpoints

* feat(grid): add horizontal gutters

* feat(spacers): use linear spacer progression

BREAKING CHANGE: all ma-x etc. helpers need to be changed

before: 0 4 8 16 24 48
after:  0 4 8 12 16 20 24 28 32 36 40 44 48

* refactor(VCol): remove redundant col prop

* fix(VCol): apply class when breakpoints specified

* feat: merge legacy-grid back into vuetify

v-layout and v-flex now coexist with the new components

some styles will still change from 1.x as there is some overlap between
the two systems, but the overall upgrade workload should be less

* docs: update classes

* feat: add back start/end spacing helpers for rtl

* feat: revert space-between -> between breaking change

* style: fix lint

* test: update snapshots

* docs: revert space-between -> between breaking change

partially reverts fc21169

* chore(ci): build before lint

eslint-plugin-vuetify needs to import from dist

* style: fix lint

* fix(VDataTable): replace text-xs-start

* style: fix lint

* fix(VRow): add flex-grow for IE11
@KaelWD
Copy link
Member

KaelWD commented Jul 20, 2019

Grid-list still works the same broken way, but the new grid system has gutters that can be set for each v-row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: enhancement Functionality that enhances existing features T: feature A new feature
Projects
None yet
Development

No branches or pull requests

6 participants