Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] normal text opacity changed in md2 #9366

Closed
185driver opened this issue Oct 15, 2019 · 2 comments · Fixed by socialsoftware/quizzes-tutor#55 or drakeg/vue_learn#9
Closed
Labels
a11y Accessibility issue good first issue A quick-win fix that would be great for new contributors md2 The issue pertains to Material Spec 2 S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features

Comments

@185driver
Copy link
Contributor

185driver commented Oct 15, 2019

Environment

Vuetify Version: 2.1.3
Vue Version: 2.6.10
Browsers: Chrome 78.0.3904.50
OS: Windows 10

Steps to reproduce

Note the text color of v-card-text components in the browser's dev-tools.

Expected Behavior

The normal text color should be #00000099.

Actual Behavior

The normal text color is instead #0000008a. This results in a reduced contrast of approximately 4.61 rather than approximately 5.74.

Reproduction Link

https://codepen.io/185driver/pen/rNNLNZG

Other comments

Google discusses the use of 60% opacity (instead of the older 54% opacity) for normal text in various places:
https://material.io/design/color/text-legibility.html#text-backgrounds
https://material.io/components/dialogs/#specs
https://material.io/components/cards/#specs

It's a small change, but it does help a bit, and appears to be the new spec. There may also be other components affected. My observation so far has been related to cards and dialogs.

@ghost ghost added the S: triage label Oct 15, 2019
@KaelWD KaelWD added T: enhancement Functionality that enhances existing features a11y Accessibility issue good first issue A quick-win fix that would be great for new contributors md2 The issue pertains to Material Spec 2 and removed S: triage labels Oct 18, 2019
@venikman
Copy link
Contributor

I will try to do it on the weekend if no one doesn't mind.

@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Nov 11, 2019
@johnleider
Copy link
Member

Now that's some attention to detail, good find @185driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue good first issue A quick-win fix that would be great for new contributors md2 The issue pertains to Material Spec 2 S: has PR The issue has a pending Pull Request T: enhancement Functionality that enhances existing features
Projects
None yet
5 participants