Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VPagination): max length #9423

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Conversation

dmitriytat
Copy link
Contributor

Fix calculation of max pagination length.

Description

Pagination should not show more pages than was setted in totalVisible.

Motivation and Context

I have over 74000 pages and now VPagination render them all before maxButtons is calculated, it cause some performance issues.

How Has This Been Tested?

unit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@TravisBuddy
Copy link

TravisBuddy commented Oct 21, 2019

Hey @dmitriytat,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 46f373e0-f428-11e9-9e15-dd9742ab6bc9

@dsseng dsseng merged commit 1394b6c into vuetifyjs:master Oct 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants