Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTable): overlapping text in mobile rows #9639

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Nov 9, 2019

Description

mobile rows had fixed height of 48px which made long texts overlap.

Motivation and Context

closes #8761

How Has This Been Tested?

playground

Markup:

<template>
  <div>
    <v-data-table
      :headers="headers"
      :items="items"
      :items-per-page="5"
      class="elevation-1"
    ></v-data-table>
  </div>
</template>

<script>
export default {
  data () {
    return {
      headers: [
        {
          text: 'Dessert (100g serving)',
          align: 'left',
          sortable: false,
          value: 'name',
        },
        { text: 'Calories', value: 'calories' },
        { text: 'Fat (g)', value: 'fat' },
        { text: 'Iron (%)', value: 'iron' }
      ],
      items: [
        {
          name: 'Frozen Yogurt',
          calories: 'Long string description Long string description Long string description Long string description Long string description ',
          fat: 'Long string description Long string description Long string description Long string description Long string description ',
          iron: 'Long string description Long string description Long string description Long string description Long string description ',
        },
        {
          name: 'Other',
          calories: 'Long string description Long string description Long string description Long string description Long string description ',
          fat: 'Long string description Long string description Long string description Long string description Long string description ',
          iron: 'Long string description Long string description Long string description Long string description Long string description ',
        }
      ]
    }
  },
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@nekosaur nekosaur added the C: VDataTable VDatatable label Nov 9, 2019
@nekosaur nekosaur added this to the v2.1.x milestone Nov 9, 2019
@nekosaur nekosaur self-assigned this Nov 9, 2019
@johnleider johnleider merged commit 0f84349 into master Nov 20, 2019
@johnleider johnleider deleted the fix/8761-data-table-mobile-overlap branch November 20, 2019 22:33
@lock lock bot locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VDataTable VDatatable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Data Iterator overlap with long labels
2 participants