-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing ltr() rules #9649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekkarczmarczyk
force-pushed
the
refactor/add-missing-ltr-rules
branch
from
November 11, 2019 05:23
85f4c4c
to
813784e
Compare
8 tasks
johnleider
previously requested changes
Nov 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good as far as I'm concerned. Only feedback would be to ensure that there is a blank line between ltr and rtl definitions.
This comment has been minimized.
This comment has been minimized.
KaelWD
changed the title
refactor: add missing ltr() rules
fix: add missing ltr() rules
Nov 18, 2019
done |
johnleider
approved these changes
Nov 22, 2019
This was referenced Dec 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7586 every
rtl()
rule should have a correspondingltr()
oneMotivation and Context
rtl/ltr/bidi build
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).