Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing ltr() rules #9649

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Conversation

jacekkarczmarczyk
Copy link
Member

For #7586 every rtl() rule should have a corresponding ltr() one

Motivation and Context

rtl/ltr/bidi build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good as far as I'm concerned. Only feedback would be to ensure that there is a blank line between ltr and rtl definitions.

@KaelWD

This comment has been minimized.

@KaelWD KaelWD changed the title refactor: add missing ltr() rules fix: add missing ltr() rules Nov 18, 2019
@jacekkarczmarczyk
Copy link
Member Author

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants