Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v-show, to avoid missing @leave transitions #163

Closed
urbgimtam opened this issue Dec 18, 2023 · 4 comments
Closed

Support v-show, to avoid missing @leave transitions #163

urbgimtam opened this issue Dec 18, 2023 · 4 comments

Comments

@urbgimtam
Copy link

At its current state, vueuse/motion only seems to work on v-if, which creates problems for @Leave transitions, whenever its required to use a conditional on the component.

With v-if, a component/element is removed from the DOM as soon as the state changes. This happens before the @Leave has a chance to run.

If motion would support v-show, those issues would not happen.

@louisjrdev
Copy link

+1 I am animating a list of elements in and want to animate them out on click of a button, can't seem to trigger this if v-if unloads the elements before an animation can happen and v-show is not supported either.

@e-tho
Copy link

e-tho commented Feb 20, 2024

+1, v-if can have a negative impact on SEO compared to v-show.

Copy link

Would you be able to provide a reproduction? 🙏

More info

Why do I need to provide a reproduction?

Reproductions make it possible for us to triage and fix issues quickly with a relatively small team. It helps us discover the source of the problem, and also can reveal assumptions you or we might be making.

What will happen?

If you've provided a reproduction, we'll remove the label and try to reproduce the issue. If we can, we'll mark it as a bug and prioritize it based on its severity and how many people we think it might affect.

If needs reproduction labeled issues don't receive any substantial activity (e.g., new comments featuring a reproduction link), we'll close them. That's not because we don't care! At any point, feel free to comment with a reproduction and we'll reopen it.

How can I create a reproduction?

A link to a stackblitz project or public GitHub repository would be perfect. 👌

Please ensure that the reproduction is as minimal as possible.

You might also find these other articles interesting and/or helpful:

Copy link

github-actions bot commented Mar 2, 2024

This issue was closed because it was open for 7 days without a reproduction.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants