Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useArrayReduce): new function #1874

Closed
wants to merge 10 commits into from

Conversation

yjl9903
Copy link
Contributor

@yjl9903 yjl9903 commented Jul 12, 2022

Description

Reactively array reduce.

import { useArrayReduce } from '@vueuse/core'

const sum = useArrayReduce([ref(1), ref(2), ref(3)], (sum, val) => sum + val)
// sum.value: 6

Use with reactive array

import { useArrayReduce } from '@vueuse/core'

const list = reactive([1, 2])
const sum = useArrayReduce(list, (sum, val) => sum + val)

list.push(3)
// sum.value: 6

Use with initialValue

import { useArrayReduce } from '@vueuse/core'

const list = reactive([{ num: 1 }, { num: 2 }])
const sum = useArrayReduce(list, (sum, val) => sum + val.num, 0)
// sum.value: 3

Additional context

#1812 (comment)

Port from #1831


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Please rebase the PR. It contains unrelated commits.

I think I am not familiar with some git operations.

And I will create another PR, this should be closed.

@yjl9903 yjl9903 mentioned this pull request Jul 12, 2022
13 tasks
@antfu
Copy link
Member

antfu commented Jul 12, 2022

Please rebase the PR and resolve the conflicts

@yjl9903
Copy link
Contributor Author

yjl9903 commented Jul 14, 2022

Is it necessary to create another function useReduceRight? Or, just have an option like { direction?: 'left' | 'right' } / { right?: boolean } to config using reduce or reduceRight.

Same as find and findLast.

@antfu
Copy link
Member

antfu commented Jul 14, 2022

Please rebase the PR. It contains unrelated commits.

@antfu
Copy link
Member

antfu commented Jul 14, 2022

Is it necessary to create another function useReduceRight?

Probably no for now. I shall implement the most basic ones and iterates later.

@yjl9903 yjl9903 closed this Jul 14, 2022
@yjl9903 yjl9903 mentioned this pull request Jul 14, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants