fix(useMediaControls): better representation for "waiting" value #3072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
"waiting" only fires when there's a lack of data in the middle of the playback. However, it doesn't take into account the lack of data when the source is attached to the element, as "loadeddata" does. I think it's safe to assume people want from "waiting" all possible buffering states. In the probably scarce cases where the user wants more control over the native event handlers, native event handlers can still be used.
"playing" also represents when a current playback is happening now.
馃 Generated by Copilot at b092cfe
Improved media controls state handling by
useMediaControls
. Added support for more media events and states, such aswaiting
andplaying
.馃 Generated by Copilot at b092cfe
useMediaControls
function to handle more media events and states (link)