Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Normalizr #553

Closed
kiaking opened this issue Feb 1, 2020 · 2 comments · Fixed by #573
Closed

Update Normalizr #553

kiaking opened this issue Feb 1, 2020 · 2 comments · Fixed by #573
Assignees
@cuebit
Labels
enhancement New feature or request resolved Issue have been resolved but not yet released
Milestone
v1.0.0

Comments

@kiaking
Copy link
Member

kiaking commented Feb 1, 2020

Normalizr 3.5.0 is out but if we update, test fails. Haven't looked into it yet but we need to fix it.
@kiaking kiaking added enhancement New feature or request ready to implement Ready to be implemented but no one has yet started labels Feb 1, 2020
@kiaking kiaking added this to the v1.0.0 milestone Feb 1, 2020
@cuebit
Copy link
Member

cuebit commented Feb 23, 2020

Looking at this diff it looks like getId is now called before the processStrategy hook rather than after. The current process mutates the input after the id for the entity is collected so it has no effect.

Vuex ORM's current ProcessStrategy simply generates the required id's so in theory it could be renamed to IdAttribute, provided as a closure for the idAttribute API and the processStrategy hook dropped altogether (and can be reinstated later if the input requires any additional mutation).

cuebit added a commit to cuebit/vuex-orm that referenced this issue Feb 23, 2020
@cuebit
fix(deps): breaking changes in Normalizr 3.5
566d482 
additionally fixes reference issues

resolves vuex-orm#553, vuex-orm#516
closes vuex-orm#564
@cuebit cuebit mentioned this issue Feb 23, 2020
Closed
cuebit added a commit to cuebit/vuex-orm that referenced this issue Feb 23, 2020
@cuebit
fix(deps): breaking changes in Normalizr 3.5
3c64272 
additionally fixes reference issues

resolves vuex-orm#553, vuex-orm#516
closes vuex-orm#564
@cuebit cuebit mentioned this issue Feb 23, 2020
Merged
@cuebit
Copy link
Member

cuebit commented Feb 24, 2020

This patch works with the new 3.6.0 release also.

@kiaking kiaking added in progress The implementation is in progress and removed ready to implement Ready to be implemented but no one has yet started labels Feb 25, 2020
kiaking added a commit that referenced this issue Mar 8, 2020
@kiaking
Merge pull request #573 from cuebit/bugfix/normalizr-bc
3c2d219 
fix(deps): #553 breaking changes in Normalizr 3.5 (v2)
@kiaking kiaking added resolved Issue have been resolved but not yet released and removed in progress The implementation is in progress labels Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuebit cuebit

Labels
enhancement New feature or request resolved Issue have been resolved but not yet released
Projects
None yet
Milestone
v1.0.0
2 participants
@cuebit @kiaking