Many-to-many relations orderBy constraint does not resolve

[cuebit]

Description

Using orderBy constraint on nested relations does not fulfil the order criteria.

This seems to be affecting the following relationships:

• Many To Many
• Has Many Through
• One To Many (Polymorphic)
• Many To Many (Polymorphic)

Steps to reproduce

1. Create a model with at least one many-to-many relationship.

static fields() {
   return {
      id: this.attr(null),
      roles: this.belongsToMany(Role, RoleUser, 'user_id', 'role_id')
   }
}

2. Supply some data.

User.create({
  data: {
    id: 1,
    roles: [
      { id: 1 },
      { id: 3 },
      { id: 2 }
    ]
  }
})

3. Retrieve the data with the relation constraint.

const user = User.query().with('roles', (query) => { query.orderBy('id') }).find(1)

Expected behaviour

The user roles should be in ascending order by id.

{
  id: 1,
  roles: [
    { id: 1 }, // Role
    { id: 2 }, // Role
    { id: 3 }  // Role
  ]
} // User

The order is actually symmetrical to the order the records, pivots et all, are created.

{
  id: 1,
  roles: [
    { id: 1 }, // Role
    { id: 3 }, // Role
    { id: 2 }  // Role
  ]
} // User

Demo

An example of a Many To Many implementation can be found here.

Versions

• Vuex ORM: 0.35.2
• All previous versions since orderBy feat was introduced.

[kiaking]

Thanks for finding this out! Is the fix ready...?

[cuebit]

The commit resolves all but has-through. I still need to look into this one.

[kiaking]

Oh OK. Great. Thank you for working on it! 🤝