fix: nested relationship orderBy constraints

[cuebit]

Description

Resolves #571 it is reported that nested relations do not observe any ordering constraints applied to them.

Type of PR:

• Bugfix
• Feature
• Enhancement
• Documentation
• Other

Breaking changes:

• No
• Yes

Issue Recap

• Applying orderBy constraint on nested relations is ignored and relationships are loaded in the order in which they were inserted.
• In some cases where primary keys are integers, the ordering is unreliable because numeric object keys do not preserve the order in which the dictionary is created.

Proposed Solution

• Use Map to generate relation indexes to make sure the ordering is preserved for numeric keys.
• Only iterate over recursive relations if the relation query contains any order constraints to avoid expensive iterations for relations without.

[codecov]

Codecov Report

Merging #586 into master will not change coverage by %.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #586    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           47        48     +1     
  Lines         1863      2169   +306     
  Branches       258       331    +73     
==========================================
+ Hits          1863      2169   +306     

Impacted Files	Coverage Δ
src/query/Query.ts	100.00% <0.00%> (ø)
src/schema/Schema.ts	100.00% <0.00%> (ø)
src/query/processors/Normalizer.ts	100.00% <0.00%> (ø)
src/schema/IdAttribute.ts	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b03d84...3115b9b. Read the comment docs.

[kiaking]

Wonderful! Thank you so much 👍