-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added Reflect.ownKeys polyfill to support IE11 #332
Conversation
Fix: Added Reflect polyfill to support IE11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! thank you so much for the PR! Could you take a look at my comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! However, it is now conflicted. Sorry for asking small things but could you rebase this to the master 😓 ?
It's passing though...
Thanks! But the conflict looks like its on builded files. Could you try removing the files under |
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 49 49
Lines 1498 1498
Branches 100 100
=====================================
Hits 1498 1498 Continue to review full report at Codecov.
|
Oh dear I think I rebased before pulling so it duplicated the commits...is there any way to revert this without force pushing? |
@SebastianSmolorz Ah, Not so sure. But it is OK to force push this PR though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Issue: #314
Tested in IE11, to reproduce try:
Person.query().with('nationality').get()