Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added Reflect.ownKeys polyfill to support IE11 #332

Merged
merged 12 commits into from
Apr 23, 2019

Conversation

SebastianSmolorz
Copy link
Contributor

@SebastianSmolorz SebastianSmolorz commented Apr 9, 2019

Issue: #314

Tested in IE11, to reproduce try:

Person.query().with('nationality').get()

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! thank you so much for the PR! Could you take a look at my comment?

package.json Outdated Show resolved Hide resolved
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! However, it is now conflicted. Sorry for asking small things but could you rebase this to the master 😓 ?

@kiaking
Copy link
Member

kiaking commented Apr 19, 2019

Thanks! But the conflict looks like its on builded files. Could you try removing the files under dist folder from the commits?

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #332   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          49     49           
  Lines        1498   1498           
  Branches      100    100           
=====================================
  Hits         1498   1498

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37dc718...83c3ed3. Read the comment docs.

@SebastianSmolorz
Copy link
Contributor Author

Oh dear I think I rebased before pulling so it duplicated the commits...is there any way to revert this without force pushing?

@kiaking
Copy link
Member

kiaking commented Apr 19, 2019

@SebastianSmolorz Ah, Not so sure. But it is OK to force push this PR though.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@kiaking kiaking merged commit 3882cd0 into vuex-orm:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants