Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkger build: no recipes to build #63

Closed
jonahweissman opened this issue Jul 19, 2021 · 4 comments · Fixed by #68
Closed

pkger build: no recipes to build #63

jonahweissman opened this issue Jul 19, 2021 · 4 comments · Fixed by #68
Labels
C-documentation Category: Improvements or additions to documentation

Comments

@jonahweissman
Copy link

Running pkger build produces:

WARN  no recipes to build

However, pkger list recipes outputs a non-empty list. I can share the whole trace from pkger build, but it seems like the important part is just this:

TRACE opts=Opts {
    quiet: false,
    debug: false,
    trace: true,
    filter: None,
    config: None,
    command: Build(
        BuildOpts {
            recipes: [],
            simple: None,
            images: None,
            docker: None,
            all: false,
            no_sign: false,
        },
    ),
}
@vv9k
Copy link
Owner

vv9k commented Jul 20, 2021

I think this is desired behavior, but perhaps could be better documented. Previously pkger build would build all recipes for all image targets and that is something not everyone expects as it might lead to a lot of builds started without the users intent. Right now if you want to build all images you have to explicitly add pkger build --all or specify the recipes that you want to build pkger build recipe1 recipe2...

@vv9k vv9k added C-documentation Category: Improvements or additions to documentation C-bug Category: issue or a bug and removed C-bug Category: issue or a bug labels Jul 20, 2021
@jonahweissman
Copy link
Author

Okay, that makes sense. I'm not quite sure where I got the impression that it would build everything. Maybe pkger build could output the intended usage if invoked without any recipes or flags?

@vv9k
Copy link
Owner

vv9k commented Jul 22, 2021

That does sound like a good idea, I added initial warning message in #68. Do you think this message is enough or should it display some more usage options?

@jonahweissman
Copy link
Author

Looks perfect! Thank you

@vv9k vv9k closed this as completed in #68 Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-documentation Category: Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants