Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VVM should not use tqdm unless tqdm is installed #7

Closed
sabotagebeats opened this issue May 12, 2021 · 2 comments
Closed

VVM should not use tqdm unless tqdm is installed #7

sabotagebeats opened this issue May 12, 2021 · 2 comments

Comments

@sabotagebeats
Copy link

vvm/vvm/install.py

Lines 24 to 27 in 1c562ed

try:
from tqdm import tqdm
except ImportError:
tqdm = None

@iamdefinitelyahuman
Copy link
Contributor

tqdm is only required if vvm.install_vyper is called with the show_progress kwarg set to True. The docstring for this method states that when using show_progress you must have installed tqdm. In my mind this isn't an issue, as you can mitigate it by not requesting a progress bar or including tqdm as an upstream dependency.

@fubuloubu
Copy link
Member

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants