mix format new fixer for elixir lang
#1017
Conversation
carakan
changed the title
mix format new fixer for elixir lang
carakan
force-pushed
the
elixir_format
branch
from
e2f8e22
to
eef9d38
Compare
autoload/ale/elixir.vim
Outdated
| " | ||
| function! ale#elixir#Executable(buffer, executable) abort | ||
| let l:elixir = ale#elixir#GetExecutable(a:buffer) | ||
| if l:elixir ==# '' |
There was a problem hiding this comment.
Travis will tell you to use is# instead. I actually checked the difference in speed between x is# '' and empty(x) just now, and the former is a little faster, so I'll accept either for checking for empty strings.
There was a problem hiding this comment.
I recommend moving all of this code into the file for the fixer instead.
autoload/ale/elixir.vim
Outdated
| " Author: carakan <carakan@gmail.com> | ||
| " Description: Functions for working with Elixir exec. | ||
|
|
||
| call ale#Set('elixir_executable', '') |
There was a problem hiding this comment.
It's unusual to have an executable option default to an empty string in the codebase. This option could be confused with an option for executing elixir for linting. You ought to default all executables to some name for something that can be found in PATH.
If you need to typically run mix instead of elixir mix, I recommend renaming this option to something like g:ale_elixir_mix_elixir_executable, or something. Then it should be okay for that to be an empty string by default, if mix is typically better than elixir mix.
Document the behavior of both options.
There was a problem hiding this comment.
@w0rp you're right I'll delete the elixir option.
carakan
force-pushed
the
elixir_format
branch
2 times, most recently
from
b2c84a0
to
2f97afa
Compare
(only available in elixir > 1.6)
carakan
force-pushed
the
elixir_format
branch
from
b8936ce
to
d37b73a
Compare
carakan
force-pushed
the
elixir_format
branch
from
d37b73a
to
be1377f
Compare
carakan
changed the title
mix format new fixer for elixir langmix format new fixer for elixir lang
|
added documentation. |
|
Looks good! 👍 I shall merge this later. I'm getting ready to release 1.6.0. |
|
Cheers! 🍻 |
the idea is to add support for new code formatter from elixir 1.6 (no yet released) but is usable compiling from master repository.
Let me know any suggestions, thanks for this awesome plugin.