Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't build in VS2017 #48

Closed
MajickTek opened this issue Jan 13, 2018 · 10 comments
Closed

doesn't build in VS2017 #48

MajickTek opened this issue Jan 13, 2018 · 10 comments

Comments

@MajickTek
Copy link

The code doesn't build in VS2017 on Windows 10 Home. This is quite odd, the project should have been easy to migrate.

the include paths are not set up right (so it cant find the headers), and app_windows.c/.h are missing.

I can't wait to get this working though!

@w23
Copy link
Owner

w23 commented Jan 13, 2018

Seems like atto submodule isn't there. Try git submodule update --init

@MajickTek
Copy link
Author

Thanks a lot! I'll report back if this doesn't work.

@MajickTek
Copy link
Author

haven't tried this yet, but i need to download git.

how could i download the dependencies without git or github desktop?

@w23
Copy link
Owner

w23 commented Jan 17, 2018

You need to download this https://github.com/w23/atto and put it into src/atto

@MajickTek
Copy link
Author

that's what I thought. thanks!

I might try this on a linux/Mac machine as well, with the provided makefile. not expecting it to work, but I'll give it a try!

@w23
Copy link
Owner

w23 commented Jan 17, 2018

Linux (and Raspberry Pi) should work.
Mac will not work, as atto doesn't support macOS at all (yet)

@MajickTek
Copy link
Author

oh. thanks anyway!

@MajickTek
Copy link
Author

I went into VS2017 and it seemed to be working fine.

However, upon building, I got two warnings and two errors:

Severity	Code	Description	Project	File	Line	Suppression State
Warning	C4047	'function': 'HRAWINPUT' differs in levels of indirection from 'LPARAM'	OpenSource	c:\users\kennedy\downloads\opensource-master\opensource-master\src\atto\src\app_windows.c	322	
Warning	C4024	'GetRawInputData': different types for formal and actual parameter 1	OpenSource	c:\users\kennedy\downloads\opensource-master\opensource-master\src\atto\src\app_windows.c	322	
Error	LNK2019	unresolved external symbol glCompressedTexImage2D referenced in function renderTextureUpload	OpenSource	C:\Users\Kennedy\Downloads\OpenSource-master\OpenSource-master\render.obj	1	
Error	LNK1120	1 unresolved externals	OpenSource	C:\Users\Kennedy\Downloads\OpenSource-master\OpenSource-master\x64\Debug\OpenSource.exe	1	

w23 added a commit that referenced this issue Feb 4, 2018
@w23
Copy link
Owner

w23 commented Feb 4, 2018

Thank you for reporting these. I don't have a Windows machine at hand right now. Could you check that this branch https://github.com/w23/OpenSource/tree/48-fix-win-build fixes the issue?

@w23 w23 closed this as completed in 431567c Feb 4, 2018
@MajickTek
Copy link
Author

Yeah, ill do that.
Also, i should stop bothering you with this issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants