Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a new codec from EBSI implementation #63

Open
samu-gataca opened this issue Aug 17, 2023 · 4 comments
Open

Include a new codec from EBSI implementation #63

samu-gataca opened this issue Aug 17, 2023 · 4 comments

Comments

@samu-gataca
Copy link

Hi there,
I'm reaching out you to try to include the EBSI specification into the did key specification.
https://api-pilot.ebsi.eu/docs/specs/did-methods/did-method-for-natural-person#schema-of-the-method-specific-identifier

As you can see in the implementation, there is a multicodec approach

With this public key P-256
{ "crv": "P-256", "kty": "EC", "x": "Lyzu4hajYTyIBGeg31gneDkID1iiUapPONRPIrG8l4Y", "y": "iMLobYRurzjfgfJS-CbAPMA8xrVsA8QgQdimEu_W-yo" }
The DID generated is
did:key:z2dmzD81cgPx8Vki7JbuuMmFYrWPgYoytykUZ3eyqht1j9KbpaxuVPhKtEdpKCagY9XhyyyzNUPwwd4ookwVpAMkkMnKkNWWUJrSYPuShZp8dPKs17kBZqqfz3vDn3QQUT9EEiZN59AGSnDFxYLaRb2DawMkRhJth6U76FuKuWPZJE3v2G

In your specification there is the possibility to use this kind of codifications, so we are requesting to add this new one to the list included into the did method.

image
@alenhorvat
Copy link

Thank you @samu-gataca

@dmitrizagidulin
Copy link
Collaborator

@samu-gataca fascinating approach...

@samu-gataca
Copy link
Author

Hi there, any new about this topic?
Regards

@reinkrul
Copy link

reinkrul commented Oct 13, 2023

I'm opposed to this. It would make did:key implementations very cumbersome to make "complete": the DID method specification limits what you need to support (NIST-EC and RSA-family, and some other curves), but now you're including a container type (JWK) which can be anything JWK supports, including symmetric or private keys.

I.m.o., if you're handling JWKs, use did:jwk.

ianhamilton87 added a commit to ianhamilton87/ssi that referenced this issue Aug 15, 2024
Enhance did:key functionality to resolve [EBSI-style did:keys](https://hub.ebsi.eu/vc-framework/did/natural-person).

They use the JWK_JCS-PUB multicodec.

Relevant issues that are related to this PR:
[w3c-ccg/did-method-key#63](w3c-ccg/did-method-key#63)
[spruceid#536](spruceid#536)

Re-do of former PR spruceid#545
ianhamilton87 added a commit to ianhamilton87/ssi that referenced this issue Aug 15, 2024
Enhance did:key functionality to resolve [EBSI-style did:keys](https://hub.ebsi.eu/vc-framework/did/natural-person).

They use the JWK_JCS-PUB multicodec.

Relevant issues that are related to this PR:
[w3c-ccg/did-method-key#63](w3c-ccg/did-method-key#63)
[spruceid#536](spruceid#536)

Re-do of former PR spruceid#545
ianhamilton87 added a commit to ianhamilton87/ssi that referenced this issue Aug 28, 2024
Enhance did:key functionality to resolve [EBSI-style did:keys](https://hub.ebsi.eu/vc-framework/did/natural-person).

They use the JWK_JCS-PUB multicodec.

Relevant issues that are related to this PR:
[w3c-ccg/did-method-key#63](w3c-ccg/did-method-key#63)
[spruceid#536](spruceid#536)

Re-do of former PR spruceid#545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants